Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit newer Solargraph versions #41

Closed

Conversation

jaredcwhite
Copy link

This just updates the Solargraph dependency in the gemspec to 0.45 with the ability to update to 0.46, etc. I haven't done an extensive test but it seems to be working fine in my project.

@jaredcwhite
Copy link
Author

Hmm, just saw this issue with loading find on an association:

Message: [Solargraph::ComplexTypeError] Unclosed subtype in ActiveRecord::Associations::CollectionProxy

Not sure if that's due to the version bump or just some other thing.

@grncdr
Copy link
Collaborator

grncdr commented Sep 12, 2022

@jaredcwhite that sounds like castwide/solargraph#589, which has been fixed but I don't think it's in a release yet

@Earlopain
Copy link

Earlopain commented Oct 19, 2022

The fix seems to have been released in 0.47.0. #47 is a duplicate of this. I wanted to try this gem and was confused when some of the features were not working as advertised, but it installed the old version 0.3.1 because of the version of solargraph I already have in my lockfile.

#43 also increments the solargraph version, but still includes a patch number. I guess solargraph doesn't provide a stable api to hook into, and this is required so it doesn't break all the time?

@alisnic
Copy link
Collaborator

alisnic commented Nov 2, 2022

@jaredcwhite please do a pull from master so that CI runs properly

@gwillcox-r7
Copy link

Might be good to close this now that #49 has landed which essentially fixes this issue.

@jaredcwhite jaredcwhite closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants