Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http implementation to manage topics #16

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

jr-araujo
Copy link
Collaborator

This PR fixed HTTP method implementations that are used to manage Topics.

  • All tests related to methods to manage topics were fixed
  • Fixed client core contracts to be aligned with Iggyrs core changes
  • Changed sealed classes to record (these classes are used just to be a data container)

@jr-araujo jr-araujo changed the title Fix http implementation to managing topics Fix http implementation to manage topics Sep 10, 2024
@@ -144,7 +144,8 @@ await _fixture.HttpSut.Invoking(y => y
// })).ToArray();
// await Task.WhenAll(tasks);
}


// [Fact(Skip = SkipMessage), TestPriority(7)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably can be deleted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be passed on to merging branches. I'm going to delete it now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jr-araujo jr-araujo requested review from numinnex and removed request for lukaszzborek September 10, 2024 10:42
@numinnex numinnex merged commit 302fa76 into master Sep 10, 2024
2 checks passed
@jr-araujo jr-araujo deleted the fix-http-topics branch September 10, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants