Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve partition ID calculation #1236

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Improve partition ID calculation #1236

merged 1 commit into from
Sep 11, 2024

Conversation

spetz
Copy link
Collaborator

@spetz spetz commented Sep 11, 2024

No description provided.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 10810851619

Details

  • 4 of 7 (57.14%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 76.6%
Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/streaming/topics/consumer_group.rs 3 6 50.0%
Files with Coverage Reduction New Missed Lines %
server/src/tcp/tcp_listener.rs 1 77.27%
server/src/http/streams.rs 1 97.64%
server/src/quic/listener.rs 1 83.33%
server/src/streaming/systems/users.rs 1 88.15%
Totals Coverage Status
Change from base Build 10778627243: -0.01%
Covered Lines: 24610
Relevant Lines: 32128
💛 - Coveralls

@spetz spetz merged commit 4149a19 into master Sep 11, 2024
17 checks passed
@spetz spetz deleted the calculate_partition_id branch September 11, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BartoszCiesla BartoszCiesla BartoszCiesla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spetz @coveralls @BartoszCiesla