-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Count of launches a validator was involved in #68
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit 05928a0): https://ignite-new--pr68-feat-validator-count-r1aypsxj.web.app (expires Thu, 05 May 2022 13:00:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
I believe this PR will be closing issue 60, so I've linked them. |
Can't verify this is working. For example, https://ignite-new--pr68-feat-validator-count-r1aypsxj.web.app/projects/30/validators Says "no validators", but
Shows 1 validator. I understand that this PR is about validator count, but still. I can see a project where a validator is validating for "1 other project", though. https://ignite-new--pr68-feat-validator-count-r1aypsxj.web.app/projects/25/validators Now I want to be able to see 2, 3, etc. |
@fadeev Sorry, I should mention, this will only work with validators created since yesterday (27/04/2022) since that's when a new version of CLI was merged and deployed. |
I've created these chains and validators roughly 30 min ago. |
Maybe, I missed something. Please, try publishing 3 chains, apply as a validator (from a different machine, Gitpod is fine), and get requests approved. You should be able to see "validates for 2 other projects". |
@fadeev Problem 2 - your three validators not showing up: I need to rework this entire logic, as per comments in Slack - use a custom new endpoint specifically for this. It should solve problem 2 as well. |
Blocked until tendermint/spn#755 resolved. |
On validator card, there is a number of launches where a validator with this operator address was in.
Uses
tx_search
RPC endpoint.Changed "Also validates" to "Validates" as most of validators will have 0 other projects.