Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Count of launches a validator was involved in #68

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Matthews3301
Copy link
Contributor

@Matthews3301 Matthews3301 commented Apr 27, 2022

On validator card, there is a number of launches where a validator with this operator address was in.

Uses tx_search RPC endpoint.

Changed "Also validates" to "Validates" as most of validators will have 0 other projects.

@github-actions
Copy link

github-actions bot commented Apr 27, 2022

Visit the preview URL for this PR (updated for commit 05928a0):

https://ignite-new--pr68-feat-validator-count-r1aypsxj.web.app

(expires Thu, 05 May 2022 13:00:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@fadeev
Copy link
Contributor

fadeev commented Apr 28, 2022

I believe this PR will be closing issue 60, so I've linked them.

@Matthews3301 Matthews3301 marked this pull request as ready for review April 28, 2022 12:05
@fadeev
Copy link
Contributor

fadeev commented Apr 28, 2022

Can't verify this is working. For example,

https://ignite-new--pr68-feat-validator-count-r1aypsxj.web.app/projects/30/validators

Says "no validators", but

ignite network chain show validators 30

Shows 1 validator.

I understand that this PR is about validator count, but still. I can see a project where a validator is validating for "1 other project", though.

https://ignite-new--pr68-feat-validator-count-r1aypsxj.web.app/projects/25/validators

Now I want to be able to see 2, 3, etc.

@Matthews3301
Copy link
Contributor Author

@fadeev Sorry, I should mention, this will only work with validators created since yesterday (27/04/2022) since that's when a new version of CLI was merged and deployed.

@fadeev
Copy link
Contributor

fadeev commented Apr 28, 2022

I've created these chains and validators roughly 30 min ago.

@fadeev
Copy link
Contributor

fadeev commented Apr 28, 2022

Maybe, I missed something. Please, try publishing 3 chains, apply as a validator (from a different machine, Gitpod is fine), and get requests approved. You should be able to see "validates for 2 other projects".

@Matthews3301 Matthews3301 marked this pull request as draft April 28, 2022 17:49
@Matthews3301
Copy link
Contributor Author

Matthews3301 commented Apr 28, 2022

@fadeev
Problem 1 - validator not showing up even though there's one when using CLI:
I think you're looking at web page for project 30 but CLI is querying campaign 30. This web page is using campaignID 29. CampaignID 30 is being used by project 31.

Problem 2 - your three validators not showing up:
Thank you, good spot. It seems that a validator can be added directly, without submitting a request - when Coordinator account is also a validator. In that case, request_add_validator event will not be created on chain.

I need to rework this entire logic, as per comments in Slack - use a custom new endpoint specifically for this. It should solve problem 2 as well.

@Matthews3301
Copy link
Contributor Author

Blocked until tendermint/spn#755 resolved.

@fadeev fadeev added the blocked label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validators: connect the page to the blockchain (also validates "N other projects")
2 participants