Skip to content

Commit

Permalink
remove redundancy hermes install for integration tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Pantani committed Aug 6, 2024
1 parent cee5d4a commit 29cf852
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions hermes/integration/app_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,13 @@ func TestCustomIBCTx(t *testing.T) {
require.NoError(t, err)
pluginPath := filepath.Join(filepath.Dir(filepath.Dir(dir)), "hermes")

env.Must(env.Exec("install hermes app locally",
step.NewSteps(step.New(
step.Exec(envtest.IgniteApp, "app", "install", pluginPath),
step.Workdir(app.SourcePath()),
)),
))
// We don't need to install Hermes again since it's a builtin extension.
// env.Must(env.Exec("install hermes app locally",
// step.NewSteps(step.New(
// step.Exec(envtest.IgniteApp, "app", "install", pluginPath),
// step.Workdir(app.SourcePath()),
// )),
// ))

// One local plugin expected
assertLocalPlugins(t, app, []pluginsconfig.Plugin{{Path: pluginPath}})
Expand Down Expand Up @@ -630,12 +631,13 @@ func TestTransferIBCTx(t *testing.T) {
require.NoError(t, err)
pluginPath := filepath.Join(filepath.Dir(filepath.Dir(dir)), "hermes")

env.Must(env.Exec("install hermes app locally",
step.NewSteps(step.New(
step.Exec(envtest.IgniteApp, "app", "install", pluginPath),
step.Workdir(app.SourcePath()),
)),
))
// We don't need to install Hermes again since it's a builtin extension.
// env.Must(env.Exec("install hermes app locally",
// step.NewSteps(step.New(
// step.Exec(envtest.IgniteApp, "app", "install", pluginPath),
// step.Workdir(app.SourcePath()),
// )),
// ))

// One local plugin expected
assertLocalPlugins(t, app, []pluginsconfig.Plugin{{Path: pluginPath}})
Expand Down

0 comments on commit 29cf852

Please sign in to comment.