Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fee abstraction app #130

Merged
merged 17 commits into from
Nov 5, 2024
Merged

feat: add fee abstraction app #130

merged 17 commits into from
Nov 5, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 28, 2024

needs ignite/cli#4319 be backported first

@Pantani Pantani self-assigned this Aug 28, 2024
@Pantani Pantani marked this pull request as ready for review August 28, 2024 17:26
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make the name of the app more general? Maybe this app can scaffold multiple other third party modules eventually ?

@Pantani
Copy link
Collaborator Author

Pantani commented Sep 19, 2024

Should we make the name of the app more general? Maybe this app can scaffold multiple other third party modules eventually ?

I like the idea, but it is more complex since each module has different ways to add. For example, the wasm app needs more configuration or ante handlers. Maybe we can think of a solution to do it together; I can think of some solutions, but nothing easy to do or maintain

fee-abstraction/README.md Outdated Show resolved Hide resolved
julienrbrt
julienrbrt previously approved these changes Nov 5, 2024
@julienrbrt julienrbrt merged commit c0aeb63 into main Nov 5, 2024
31 checks passed
@julienrbrt julienrbrt deleted the feat/fee-abs-app branch November 5, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants