Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(wasm): code improvements #132

Merged
merged 1 commit into from
Aug 29, 2024
Merged

refactor(wasm): code improvements #132

merged 1 commit into from
Aug 29, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Aug 28, 2024

Description

  • Use API to get home and app path instead flags;
  • Remove redundancy names;
  • Improve code quality;

@Pantani Pantani self-assigned this Aug 28, 2024
@julienrbrt julienrbrt changed the title feat: add some code improvements refactor(wasm): code improvements Aug 28, 2024
@Pantani Pantani merged commit 4f2e429 into main Aug 29, 2024
30 of 31 checks passed
@Pantani Pantani deleted the fix/improve-wasm branch August 29, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@Pantani Pantani

Labels
app:wasm ci configs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pantani @julienrbrt