Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network plugin #19

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: add network plugin #19

wants to merge 14 commits into from

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Oct 15, 2023

move the network app to the apps mono repo

We should add this to the commit before squash:

This commit migrates the [cli-plugin-network repo](https://github.com/ignite/cli-plugin-network) module to this ignite apps repository.

Co-authored-by: @tbruyelle <Thomas Bruyelle>
Co-authored-by: @Pantani <Danilo Pantani>
Co-authored-by: @jeronimoalbi <Jerónimo Albi>
Co-authored-by: @aljo242 <Alex>
Co-authored-by: @lumtis <Lucas Bertrand>
Co-authored-by: @fadeev <Denis Fadeev>
Co-authored-by: @julienrbrt <Julien Robert>

@Pantani Pantani self-assigned this Oct 15, 2023
@Pantani Pantani marked this pull request as ready for review November 8, 2023 12:53
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this!

Meanwhile, we should make it clear that this code originates from another repo and should give attributions to the other authors.

We should try finding the best way of giving attributions; at very least we can include them as co-authors by pushing an empty commit. And in the description of the commit we could add more information as/if needed.

Please see the format:

image

@Pantani Pantani marked this pull request as draft February 1, 2024 19:28
@salmad3 salmad3 removed the request for review from Ehsan-saradar July 18, 2024 22:27
# Conflicts:
#	explorer/go.mod
#	explorer/go.sum
#	go.work.example
#	integration/go.mod
@Pantani Pantani requested a review from ilgooz November 1, 2024 00:42
@Pantani Pantani marked this pull request as ready for review November 1, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants