Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Change community contributions in README #63

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

toschdev
Copy link
Contributor

Community Contributions should be in their own repository, then linked to the app-registry repository where all Apps can be found.

@toschdev toschdev self-assigned this Feb 26, 2024
@toschdev toschdev requested a review from ilgooz as a code owner February 26, 2024 11:10
@toschdev toschdev changed the title Change community contributions in README docs: Change community contributions in README Feb 26, 2024
Pantani
Pantani previously approved these changes Feb 26, 2024
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

just one suggestion

README.md Outdated Show resolved Hide resolved
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@toschdev toschdev requested a review from Pantani February 27, 2024 09:28
Copy link
Member

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice:) Two fast follows:

  • May we add a real example?
  • Let's ensure we add links (like to the app registry repo, apps directory, etc.)

@Pantani Pantani merged commit 2cfb6cd into main Mar 4, 2024
12 checks passed
@Pantani Pantani deleted the docs/readme branch March 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants