Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix and refactor gex app #81

Merged
merged 20 commits into from
Apr 23, 2024
Merged

fix: fix and refactor gex app #81

merged 20 commits into from
Apr 23, 2024

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Mar 25, 2024

Description

  • The Gex app was not working when we passed a custom RPC address;
  • Add gex integration tests;
  • Use ignite/gex@v1.0.0 instead cosmos/gex;

Pantani and others added 5 commits April 1, 2024 20:17
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
Co-authored-by: Jerónimo Albi <jeronimo.albi@gmail.com>
# Conflicts:
#	explorer/integration/gex_test.go
@Pantani Pantani enabled auto-merge (squash) April 15, 2024 21:49
salmad3
salmad3 previously approved these changes Apr 21, 2024
Copy link
Member

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

explorer/CHANGELOG.md Outdated Show resolved Hide resolved
explorer/go.mod Outdated Show resolved Hide resolved
jeronimoalbi
jeronimoalbi previously approved these changes Apr 22, 2024
Co-authored-by: Danny <salman.danny03@hotmail.com>
@Pantani Pantani dismissed stale reviews from jeronimoalbi and salmad3 via fa05cc4 April 22, 2024 10:14
@Pantani Pantani merged commit 64bafb4 into main Apr 23, 2024
26 checks passed
@Pantani Pantani deleted the feat/gex-refactor branch April 23, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants