Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignite scaffold param <name>:<type> --module <module> #3684

Closed
Olshansk opened this issue Oct 6, 2023 · 6 comments · Fixed by #3770
Closed

Add ignite scaffold param <name>:<type> --module <module> #3684

Olshansk opened this issue Oct 6, 2023 · 6 comments · Fixed by #3770
Assignees
Labels
type:request Feature request.
Milestone

Comments

@Olshansk
Copy link

Olshansk commented Oct 6, 2023

Is your feature request related to a problem or issue you encountered? Please describe.

Yes, I'd like to add a parameter to an already scaffold module.

Describe the solution you'd like

Current Flow:

# Add params when scaffolding a module
ignite scaffold module foo --params baz:uint,bar:bool

# Manually add new params after the fact

Proposed workflow:

# Scaffold a module
ignite scaffold module foo

# Scaffold params dynamically

ignite scaffold param baz:uin --module foo

Describe alternatives you've considered

Look at ignite documentation for how to add params.

  1. Scaffold a new (temp) module with params
  2. Ctrl-f for lines related to my param name
  3. Copy paste those lines in my pre-existing module

Ref: https://docs.ignite.com/references/cli

@Olshansk Olshansk added the type:request Feature request. label Oct 6, 2023
@Olshansk Olshansk changed the title Add ignite scaffold param [...]baz:uint,bar:bool --module foo` Add ignite scaffold param [...] Oct 6, 2023
@Olshansk
Copy link
Author

Olshansk commented Oct 6, 2023

cc @h5law

@Olshansk Olshansk changed the title Add ignite scaffold param [...] Add ignite scaffold param <name>:<type> --module <module> Oct 6, 2023
@Pantani Pantani moved this to Backlog in Ignite CLI Masterboard Oct 17, 2023
@Pantani Pantani modified the milestones: v0.30, v0.29 Oct 31, 2023
@Pantani Pantani self-assigned this Nov 13, 2023
@Pantani Pantani moved this from Backlog to In Progress in Ignite CLI Masterboard Nov 22, 2023
@Pantani Pantani modified the milestones: v0.29, v0.28 Nov 24, 2023
@Pantani Pantani moved this from In Progress to In Review in Ignite CLI Masterboard Nov 24, 2023
@salmad3 salmad3 modified the milestones: v28, v29 Feb 2, 2024
@github-project-automation github-project-automation bot moved this from Review / QA to Done in Ignite CLI Masterboard Feb 22, 2024
@Olshansk
Copy link
Author

@Pantani Thanks for doing this!

@Olshansk
Copy link
Author

@Pantani When I run ignite scaffold, I still can't find ignite scaffold param or ignite scaffold config.

Here is the output:

Usage:
  ignite scaffold [command]

Aliases:
  scaffold, s

Available Commands:
  chain       New Cosmos SDK blockchain
  module      Custom Cosmos SDK module
  list        CRUD for data stored as an array
  map         CRUD for data stored as key-value pairs
  single      CRUD for data stored in a single location
  type        Type definition
  message     Message to perform state transition on the blockchain
  query       Query for fetching data from a blockchain
  packet      Message for sending an IBC packet
  vue         Vue 3 web app template
  react       React web app template

Here is the version:

Ignite CLI version:		v28.5.1
Ignite CLI build date:		2024-08-05T12:50:47Z
Ignite CLI source hash:		2a968e8684cae0a1d79ccb11f0db067a4605173e
Ignite CLI config version:	v1
Cosmos SDK version:		v0.50.8

Do you know when it'll be available?

@julienrbrt
Copy link
Member

@Pantani When I run ignite scaffold, I still can't find ignite scaffold param or ignite scaffold config.

Here is the output:


Usage:

  ignite scaffold [command]



Aliases:

  scaffold, s



Available Commands:

  chain       New Cosmos SDK blockchain

  module      Custom Cosmos SDK module

  list        CRUD for data stored as an array

  map         CRUD for data stored as key-value pairs

  single      CRUD for data stored in a single location

  type        Type definition

  message     Message to perform state transition on the blockchain

  query       Query for fetching data from a blockchain

  packet      Message for sending an IBC packet

  vue         Vue 3 web app template

  react       React web app template

Here is the version:


Ignite CLI version:		v28.5.1

Ignite CLI build date:		2024-08-05T12:50:47Z

Ignite CLI source hash:		2a968e8684cae0a1d79ccb11f0db067a4605173e

Ignite CLI config version:	v1

Cosmos SDK version:		v0.50.8

Do you know when it'll be available?

Hey, it will be available on v29.

@Olshansk
Copy link
Author

@julienrbrt Is there a VERY approximate ETA for that?

Totally fine even if you say 2025. Just trying to understand if I should wait to do something or not.

@julienrbrt
Copy link
Member

@julienrbrt Is there a VERY approximate ETA for that?

Totally fine even if you say 2025. Just trying to understand if I should wait to do something or not.

You can use main right now for a v0.50 chain (until we merge 0.52 integration). V29 should be released soon after IBC is compatible with 0.52. Probably Q4 this year.

Olshansk added a commit to pokt-network/poktroll that referenced this issue Aug 26, 2024
The team at ignite responded to our feature request but it's not available yet: ignite/cli#3684.

We should update to it at some point.
Olshansk added a commit to pokt-network/poktroll that referenced this issue Aug 30, 2024
The team at ignite responded to our feature request but it's not
available yet: ignite/cli#3684.

We should update to it at some point.
okdas pushed a commit to pokt-network/poktroll that referenced this issue Nov 14, 2024
The team at ignite responded to our feature request but it's not
available yet: ignite/cli#3684.

We should update to it at some point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:request Feature request.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants