feat(network): initialize init command
#1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and refactor the network related code.
Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
ilgooz
requested changes
Nov 8, 2021
Pantani
reviewed
Nov 11, 2021
Pantani
previously approved these changes
Nov 12, 2021
ilgooz
reviewed
Nov 15, 2021
ilgooz
approved these changes
Nov 17, 2021
Pantani
approved these changes
Nov 17, 2021
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* feat(cmd): add network publish cmd and refactor the network related code. * re-add network command * hide the network cmd * Apply suggestions from code review Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * consistent event printing * docs * Command initialization * misc modifications * chain home * chain fetch * Lint * init account * Add validator description * Account creation * Add mnemonic * overwrite confirmation * Fix mnemonic typo * starport/cmd/network_chain_init.go * Initialize recover * Small modification * Network initialization * Refactor genesis and chain verification * lint * Refactor account * Fix no account * validator name change * import account command * import starport account * fix account created * Remove todos * Update starport/cmd/network_chain_init.go Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> * shutdown renaming * Validator flag * Fix cli spinner * comments * Fix genesis URL * spinner * small text change * comment * Genesis initialization * Refactor genesis url init Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starport network chain init <launch-id>allows initializing a node from aspnchain launch IDOpening now for reviews. Open for suggestion for the CLI output format
As mentioned in the specs. The account is added to the genesis with the same value as self-delegation for the gentx. If the user want to start the chain locally with the initialized genesis, it will fail begin the self-delegation tx costs gas and therefore the user account amount must be slightly higher.
Some question arise:
initcommand? This is not necessary for generating a gentx and therefore not necessary if we consider theinitcommand if the purpose of the command is solely to generate the gentx. It can still be useful if we want to allow the command to let the user testing the chain locally. Maybe it can also be wise to "simulate" the start of the chain to ensure the generate gentx is validjoincommandinitcommand we must handle a edge case: if the account is already present in a custom URL genesis we should not calladd-genesis-accountor ignore its returned errorThere is curious bug with the CLI output if my window is too short for the "do you want to erase?" question spawning 3 times. Does it happen for you?
One last thing: I used
Blockchain()method withSourceOptionto initialize the blockchain from alaunchIDbut I'm wondering if we shouldn't implement two separate methods for initialization from source URL and launch ID since both workflow seem to be pretty different