-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix app update
command and duplicated apps
#3931
Conversation
What's the steps to reproduce the bug so I can confirm this works? The issue talks about 3 different things 😅 |
The steps for the first bug are as follows:
The second is you can add the same app more than one time from different branches:
Check the app config file: apps:
- path: github.com/ignite/apps/hermes
- path: github.com/ignite/apps/hermes@feat/test-branch
- path: github.com/ignite/apps/hermes@chore/fix-go-work |
# Conflicts: # ignite/services/plugin/scaffold_test.go
app update
commandapp update
command and duplicated apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point about using plugin.HasPath()
method to compare path without the version.
(cherry picked from commit 65a4299)
(cherry picked from commit 65a4299) Co-authored-by: Danilo Pantani <danpantani@gmail.com>
close #3373
Description
app update
command;