Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix app update command and duplicated apps #3931

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Feb 1, 2024

close #3373

Description

  • Fix panic from app update command;
  • Use the GitHub namespace to find the plugin without the target;

@Pantani Pantani self-assigned this Feb 1, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd type:services Service-related issues. labels Feb 1, 2024
@julienrbrt
Copy link
Member

What's the steps to reproduce the bug so I can confirm this works? The issue talks about 3 different things 😅

@Pantani
Copy link
Collaborator Author

Pantani commented Feb 1, 2024

What's the steps to reproduce the bug so I can confirm this works? The issue talks about 3 different things 😅

The steps for the first bug are as follows:

ignite app install -g github.com/ignite/apps/hermes

ignite app update github.com/ignite/apps/hermes

The second is you can add the same app more than one time from different branches:

ignite app install -g github.com/ignite/apps/hermes
ignite app install -g github.com/ignite/apps/hermes@feat/test-branch
ignite app install -g github.com/ignite/apps/hermes@chore/fix-go-work

Check the app config file: cat ~/.ignite/apps/igniteapps.yml:

apps:
- path: github.com/ignite/apps/hermes
- path: github.com/ignite/apps/hermes@feat/test-branch
- path: github.com/ignite/apps/hermes@chore/fix-go-work

# Conflicts:
#	ignite/services/plugin/scaffold_test.go
@github-actions github-actions bot removed the type:services Service-related issues. label Feb 1, 2024
@Pantani Pantani changed the title fix: fix app update command fix: fix app update command and duplicated apps Feb 1, 2024
@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Feb 2, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK.

Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about using plugin.HasPath() method to compare path without the version.

@julienrbrt julienrbrt enabled auto-merge (squash) February 2, 2024 10:30
@julienrbrt julienrbrt merged commit 65a4299 into main Feb 2, 2024
43 of 44 checks passed
@julienrbrt julienrbrt deleted the fix/app-update branch February 2, 2024 11:12
mergify bot pushed a commit that referenced this pull request Feb 2, 2024
julienrbrt pushed a commit that referenced this pull request Feb 2, 2024
(cherry picked from commit 65a4299)

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:cmd component:configs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching plugin from a specific branch or tag
3 participants