Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apps Stdout is redirected to Stderr #3953

Merged
merged 3 commits into from
Feb 6, 2024
Merged

fix: Apps Stdout is redirected to Stderr #3953

merged 3 commits into from
Feb 6, 2024

Conversation

Ehsan-saradar
Copy link
Contributor

Closes #3951

@Ehsan-saradar Ehsan-saradar added the hotfix Urgent fixes requiring immediate attention. label Feb 6, 2024
@Ehsan-saradar Ehsan-saradar self-assigned this Feb 6, 2024
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. labels Feb 6, 2024
@Ehsan-saradar Ehsan-saradar added the skip-changelog Don't check changelog for new entries label Feb 6, 2024
@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Feb 6, 2024
julienrbrt
julienrbrt previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Can we get a changelog?

@julienrbrt julienrbrt removed the skip-changelog Don't check changelog for new entries label Feb 6, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e0c80c0) 24.78% compared to head (a189667) 24.78%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3953   +/-   ##
=======================================
  Coverage   24.78%   24.78%           
=======================================
  Files         296      296           
  Lines       24901    24896    -5     
=======================================
- Hits         6171     6170    -1     
+ Misses      18164    18160    -4     
  Partials      566      566
Files Coverage Δ
ignite/services/plugin/plugin.go 77.73% <100.00%> (-0.09%) ⬇️
ignite/cmd/plugin.go 28.67% <0.00%> (+0.21%) ⬆️

@Ehsan-saradar
Copy link
Contributor Author

@julienrbrt I believe that this issue wasn't in v28.1.1 release so i'm not sure if it requires changelog.

@julienrbrt
Copy link
Member

It does as we've released v28.2.0

@Ehsan-saradar Ehsan-saradar changed the title fix: App Stdout is redirected to Stderr fix: Apps Stdout is redirected to Stderr Feb 6, 2024
@Ehsan-saradar Ehsan-saradar enabled auto-merge (squash) February 6, 2024 12:39
jeronimoalbi
jeronimoalbi approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@jeronimoalbi jeronimoalbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ehsan-saradar Ehsan-saradar merged commit ca4445e into main Feb 6, 2024
38 of 44 checks passed
@Ehsan-saradar Ehsan-saradar deleted the fix/apps-redirect-to-stderr branch February 6, 2024 13:18
mergify bot pushed a commit that referenced this pull request Feb 6, 2024
@Ehsan-saradar @mergify
fix: Apps Stdout is redirected to Stderr (#3953)
0fae165 
* Fix stdout redirecting to stderr

* Fix unit test

* Update changelog

(cherry picked from commit ca4445e)
@mergify mergify bot mentioned this pull request Feb 6, 2024
Merged
julienrbrt added a commit that referenced this pull request Feb 6, 2024
@mergify @Ehsan-saradar @julienrbrt
fix: Apps Stdout is redirected to Stderr (backport #3953) (#3954)
c9b6dba 
* fix: Apps Stdout is redirected to Stderr (#3953)

* Fix stdout redirecting to stderr

* Fix unit test

* Update changelog

(cherry picked from commit ca4445e)

* fix conflicts

---------

Co-authored-by: Ehsan-saradar <ehsan.saradar@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt julienrbrt mentioned this pull request Mar 20, 2024
Merged
julienrbrt pushed a commit that referenced this pull request May 29, 2024
@Ehsan-saradar @julienrbrt
fix: Apps Stdout is redirected to Stderr (#3953)
4f856bc 
* Fix stdout redirecting to stderr

* Fix unit test

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Ehsan-saradar Ehsan-saradar

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs hotfix Urgent fixes requiring immediate attention. type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignite redirects plugins output to Stderr instead of Stdout
3 participants
@Ehsan-saradar @julienrbrt @jeronimoalbi