chore(services): use AppName instead ModuleName for scaffold a new App
#4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
Pantani
changed the title
AppName instead ModuleName for scaffold a new AppAppName instead ModuleName for scaffold a new App
Pantani
changed the title
AppName instead ModuleName for scaffold a new AppAppName instead ModuleName for scaffold a new App
julienrbrt
previously approved these changes
Mar 12, 2024
jeronimoalbi
previously approved these changes
Mar 12, 2024
jeronimoalbi
approved these changes
Mar 14, 2024
julienrbrt
approved these changes
Mar 18, 2024
|
Looks like there an issue with my IBC integration tests. After all those merge of the main branch I still haven't them seen pass once. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4010 +/- ##
=======================================
Coverage 26.06% 26.06%
=======================================
Files 304 304
Lines 25440 25440
=======================================
Hits 6632 6632
Misses 18232 18232
Partials 576 576
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…w App (#4010) * use AppName instead ModuleName for scaffold a new App * add changelog * fix the quote for the scaffold chain for integration tests --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 276b515)
julienrbrt
added a commit
that referenced
this pull request
Mar 19, 2024
…w App (backport #4010) (#4040) * chore(services): use `AppName` instead `ModuleName` for scaffold a new App (#4010) * use AppName instead ModuleName for scaffold a new App * add changelog * fix the quote for the scaffold chain for integration tests --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 276b515) * fix changelog --------- Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Merged
julienrbrt
added a commit
that referenced
this pull request
May 29, 2024
…w App (#4010) * use AppName instead ModuleName for scaffold a new App * add changelog * fix the quote for the scaffold chain for integration tests --------- Co-authored-by: Pantani <Pantani> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AppNameinstead ofModuleNamein the templates;AppNameto scaffold the chain app for the integration tests;