Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(templates): Set and seal SDK global config in app/config.go #4199

Merged
merged 4 commits into from
Jun 25, 2024
Merged

refactor(templates): Set and seal SDK global config in app/config.go #4199

merged 4 commits into from
Jun 25, 2024

Conversation

julienrbrt
Copy link
Member

Closes: #4185

@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Jun 20, 2024
jeronimoalbi
jeronimoalbi previously approved these changes Jun 21, 2024
View reviewed changes
@julienrbrt julienrbrt enabled auto-merge (squash) June 21, 2024 08:03
@julienrbrt julienrbrt requested a review from jeronimoalbi June 21, 2024 08:30
@julienrbrt julienrbrt merged commit dbbe52e into main Jun 25, 2024
44 checks passed
@julienrbrt julienrbrt deleted the julien/sdk-config-prefixes branch June 25, 2024 09:16
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@julienrbrt @mergify
refactor(templates): Set and seal SDK global config in app/config.go (
39c8606 
#4199)

* refactor(templates): Set and seal SDK global config in `app/config.go`

* updates

(cherry picked from commit dbbe52e)
@mergify mergify bot mentioned this pull request Jun 25, 2024
Merged
julienrbrt added a commit that referenced this pull request Jun 25, 2024
@mergify @julienrbrt
refactor(templates): Set and seal SDK global config in app/config.go (
038300a 
#4199) (#4207)

* refactor(templates): Set and seal SDK global config in `app/config.go`

* updates

(cherry picked from commit dbbe52e)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@BrewTestBot BrewTestBot mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeronimoalbi jeronimoalbi jeronimoalbi approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@julienrbrt julienrbrt

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulate fail for chains created with address-prefix setup
2 participants
@julienrbrt @jeronimoalbi