feat: Add multi node (validator) testnet #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likesToEatFish
requested review from
ilgooz,
jeronimoalbi,
Pantani and
julienrbrt
as code owners
github-actions
bot
added
component:ci
|
The feature is done, but the documentation hasn't been written yet. I plan to complete it tomorrow. |
likesToEatFish
changed the title
julienrbrt
changed the title
julienrbrt
reviewed
Sep 29, 2024
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
Show resolved
Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
Outdated
Show resolved
Hide resolved
ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet_multi_node.go.plush
Outdated
Show resolved
Hide resolved
Pantani
reviewed
Oct 14, 2024
Pantani
reviewed
Oct 14, 2024
Pantani
previously approved these changes
Oct 18, 2024
julienrbrt
reviewed
Oct 19, 2024
Pantani
reviewed
Oct 20, 2024
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
|
Thanks @julienrbrt @Pantani , I learned a lot of new things from this PR! 🙏🏾 |
|
Hi @julienrbrt @Pantani , I noticed the PR received positive feedback a few days ago but hasn't been merged yet. If there's anything further needed from my side or any blockers, please let me know. Thanks! |
Pantani
approved these changes
Oct 29, 2024
|
Hey! I'll be reviewing this today! Sorry about the delay (cosmoverse + holidays :D) |
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
* add cmd multi-node * read config * minor * init node * done * remove try * updates * updates * make format * updates * minor * rename and add info node * add a reset command * changelog * lint * use config.yml with more validators * updates docs * show log * rename package model to bubblemodel * Update ignite/cmd/testnet_multi_node.go Co-authored-by: Julien Robert <julien@rbrt.fr> * nits * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * updates * use lipgloss for View * status bar * nits * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * remove ctx * add comment * use ports in ignite/pkg/availableport/availableport.go * update errgroup * Update changelog.md Co-authored-by: Danilo Pantani <danpantani@gmail.com> * updates with v0.52 --------- Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Danilo Pantani <danpantani@gmail.com> (cherry picked from commit b7e3ab3) # Conflicts: # docs/docs/03-CLI-Commands/01-cli-commands.md # ignite/cmd/bubblemodel/chain_debug_test.go # ignite/cmd/bubblemodel/chain_serve_test.go # ignite/cmd/chain_debug.go # ignite/cmd/chain_serve.go # ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/commands.go.plush
Merged
julienrbrt
pushed a commit
that referenced
this pull request
Nov 12, 2024
julienrbrt
added a commit
that referenced
this pull request
Nov 14, 2024
* feat: Add multi node (validator) testnet (#4377) * add cmd multi-node * read config * minor * init node * done * remove try * updates * updates * make format * updates * minor * rename and add info node * add a reset command * changelog * lint * use config.yml with more validators * updates docs * show log * rename package model to bubblemodel * Update ignite/cmd/testnet_multi_node.go Co-authored-by: Julien Robert <julien@rbrt.fr> * nits * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * updates * use lipgloss for View * status bar * nits * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ignite/cmd/bubblemodel/testnet_multi_node.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * remove ctx * add comment * use ports in ignite/pkg/availableport/availableport.go * update errgroup * Update changelog.md Co-authored-by: Danilo Pantani <danpantani@gmail.com> * updates with v0.52 --------- Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: Danilo Pantani <danpantani@gmail.com> (cherry picked from commit b7e3ab3) # Conflicts: # docs/docs/03-CLI-Commands/01-cli-commands.md # ignite/cmd/bubblemodel/chain_debug_test.go # ignite/cmd/bubblemodel/chain_serve_test.go # ignite/cmd/chain_debug.go # ignite/cmd/chain_serve.go # ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/commands.go.plush * cl * feat: Add multi node (validator) testnet (backport #4377) (#4401) * resolve conflicts * revert v28 * `make lint-fix` --------- Co-authored-by: Duong NV | Decentrio <hoc.sinhphu.lam@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4374
This PR added the feature to ignite multi-node testnet.
Test steps:
ignite scaffold chain github.com/test/mychaincd mychaingo install ./...ignite testnet multi-nodeThe interface looks like this: