Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scaffold an `uint64 type crashs Ignite #4479

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Jan 23, 2025

close #4284

Description

When we Scaffold a uint64 type, Ignite understands it as a custom type because it is in the code but is not a valid default type. This PR adds uint64 and int64 as default types.

How to test
ignite scaffold params blocksPerYear:uint64 -y

@Pantani Pantani self-assigned this Jan 23, 2025
@Pantani Pantani changed the title fix: scaffold an uint64 type crashs Ignite fix: scaffold an `uint64 type crashs Ignite Jan 23, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@julienrbrt julienrbrt merged commit b3c0e5c into main Jan 23, 2025
42 of 45 checks passed
@julienrbrt julienrbrt deleted the fix/scaffold-uint64-type branch January 23, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIX: Scaffold params with uint64 crashes Ignite
2 participants