Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search position #250

Merged
merged 4 commits into from
Feb 28, 2022
Merged

fix: search position #250

merged 4 commits into from
Feb 28, 2022

Conversation

mihailmarcu
Copy link
Contributor

Description & Context

The search bar was not aligned like in the figma design.

How To Test

  1. Connect Wallet;
  2. "Assets" component must have a search field after a successful data request;
  3. Default state and focus state must be properly aligned

Linked issue

Closes #215

@mihailmarcu mihailmarcu self-assigned this Feb 28, 2022
@mihailmarcu mihailmarcu added the enhancement Improvement over existing feature label Feb 28, 2022
@marinhoarthur
Copy link
Contributor

marinhoarthur commented Feb 28, 2022

Text is still not vertically aligned. Figma says it should.

branch =
image

figma =
image

Is this ok w/ Design?

@fadeev
Copy link
Contributor

fadeev commented Feb 28, 2022

The goal is to have it aligned perfectly.

@mihailmarcu
Copy link
Contributor Author

Hey @marinhoarthur,
Let me check, but I aligned the focus state using the pixel perfect extension.

@mihailmarcu
Copy link
Contributor Author

The problem is in the design itself. Default state and focus state are aligned differently.

@mihailmarcu
Copy link
Contributor Author

Hey @marinhoarthur,
The issue is returned back for review after the changes match the latest Figma updates.

@mihailmarcu mihailmarcu merged commit 0c4d2fd into develop Feb 28, 2022
@marinhoarthur marinhoarthur deleted the feature/215_search_position branch March 9, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement over existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(ui): search bar is misaligned (assets list)
3 participants