Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin panel: Add new user: groups lookup #2536

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Sep 21, 2024

I tried to slightly improve the Admin Console to improve first impression.

When creating a user we may set a group name. I added an autocompletion for it.

Also on the user create form the browser tries to autocomplete username and other fields of the admin itself which is not needed here. I added the autocomplete="off" for inputs to fix this but Firefox may ignore it 👎

There is a task Admin console design improvements and I committed with its ticket number.

@stokito stokito force-pushed the OF-1823_groups_lookup branch 2 times, most recently from f69ac7e to 324785d Compare September 21, 2024 17:10
@akrherz
Copy link
Member

akrherz commented Sep 21, 2024

Thanks, this PR should not be backported to 4.9 branch, so I've added 324785d to an isolated PR #2537

Copy link
Member

@guusdk guusdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Would you mind applying similar changes to the room configuration screen? It's been driving me nuts that it autopopulates the password field from my browser's password manager.

I believe that the layout changes to the plugin pages can be improved a lot by a couple of small changes.

Can you move the header that reads "Description" a bit to the left, so that it aligns on the left side with the icon?

image

In the 'version' column, the version identifier (in the first line) gets centered, which is visually appealing, as the release date on the second line typically has more characters / is wider. There are some plugins where the version identifier has more characters than the release date. In the screenshot below, an example is shown of both. When the release date is shorter than the version identifier, things look a bit funky now. I would suggest centering the release date in such case.

image

I don't like the icon on the first line of the version column. It makes for a messy look. Can you please move it to the right of the version, vertically centered (so that it is in line with all other icons in the row)?

image

One final improvement that I think would be good to have is an aid for users to help them click the right 'install' button. On wider screens it's often a bit hard to make sure that the + button that's all the way on the right hand side corresponds with the name of the plugin that is all the way on the left. I think this can be improved in a couple of ways. I would choose one of these:

  • Make the background color of each row alternate (white/gray/white/gray...)
  • Make the background of a row over which the cursor is located change. I think we had this in the past, where such a row would get a yellow-ish background color.

@guusdk
Copy link
Member

guusdk commented Sep 21, 2024

Thanks, this PR should not be backported to 4.9 branch, so I've added 324785d to an isolated PR #2537

That probably means that the commit should be removed from this PR?

@stokito
Copy link
Contributor Author

stokito commented Sep 22, 2024

I removed the commit with moving of the changelog to version column but moved it into a separate draft #2541. So the PR can be merged as is.

@guusdk guusdk merged commit f8be4a6 into igniterealtime:main Sep 23, 2024
17 checks passed
@stokito stokito deleted the OF-1823_groups_lookup branch September 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants