Implementation of XEP-0308: Last Message Correction #73
Conversation
|
@Flowdalic TravisCI is killing the process of the 2nd check (java 1.7). I guess it is because of low memory. |
| @@ -0,0 +1,120 @@ | |||
| /** | |||
| * | |||
| * Copyright the original author or authors | |||
There was a problem hiding this comment.
That line should include a copyright year, i.e. 2016. And you state your name in the other copyright headers, why not here too?
|
Please squash merge all commits into a single commit and make sure that the issue's key 'SMACK-714' is mentioned somewhere in the commit message's body. Please don't put it into the title. Something like "Fixes SMACK-714" is sufficient. Uhh, and I forget to say: Thanks for your contribution. :-) |
| * | ||
| * @author Fernando Ramirez, f.e.ramirez94@gmail.com | ||
| */ | ||
| public class MessageCorrectExtension implements ExtensionElement { |
There was a problem hiding this comment.
It's Smackomatic (a Smack Idiom) that ExtensionElements have a static from() method. Since XEP-308 is only defined for messages, in this case we should have
static MessageCorrectionExtension from(Message)
Please add this method.
|
@Flowdalic Thanks for the feedback ! |
| .append(getJidInitialMessage()).append('\'').append(" xmlns='").append(getNamespace()).append("'/>"); | ||
| return stringBuilder.toString(); | ||
| public XmlStringBuilder toXML() { | ||
| XmlStringBuilder xml = new XmlStringBuilder(this, getNamespace()); |
There was a problem hiding this comment.
Just new XmlStringBuilder(this) will do the right thing, i.e. adding the opening tag and the xmlns attribute.
Some older Smack unit tests are not properly synchronized causing them to behave non deterministc especially on slow systems like the Travis CI infrastructure. I've restarted Travis (not sure if you are also able to hit the restart button, e.g. at https://travis-ci.org/igniterealtime/Smack/jobs/122258804 in the upper right corner). Looks good so far 👍 I've added a few last remarks, please incorporate the changes, then squash merge all you commits into a single commit and then force push to the source branch of this PR. |
|
By the way, this PR only implements the low-level API parts for XEP-308. While it's ok to start with them first, do you plan to submit an subsequent PR with the high-level API, i.e. the MessageCorrectionManager)? |
It's not planned up to now, but I think we can discuss it. |
|
@Flowdalic Changes done |
|
Perfect, now you need to squash the commits into one. |
|
@Flowdalic Github has a new option to do that when merge. |
|
@Flowdalic I can close this PR and open another one squashing the commits |
Simply update this PR by updating its source branch with a forced push. |
ramabit
force-pushed
the
master
branch
2 times, most recently
from
d169632
to
b3c3a43
Compare
@Flowdalic done |
|
Thanks, but the message's body now full of meaningless half sentences, it also does not contain the issue key, which is required so that JIRA connects the issue with this commit (#73 (comment)). Please fix that. |
Fix SMACK-714
@Flowdalic done |
|
Picked as ca58c65 Thanks again :) |
Fixes SMACK-714
Documentation: https://xmpp.org/extensions/xep-0308.html
How to use it
Send:
message.addExtension(new MessageCorrectExtension(idInitialMessage));Receive:
ProviderManager.addExtensionProvider(MessageCorrectExtension.ELEMENT_NAME, MessageCorrectExtension.NAMESPACE, new MessageCorrectProvider());MessageCorrectExtension messageCorrectExtension = MessageCorrectExtension.from(message)