SPARK-1994 Make use of the JRE certificates. #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
reviewed
Aug 22, 2017
| } | ||
| } | ||
| } catch (Exception e) { | ||
| Log.error(e.getMessage(), e); |
There was a problem hiding this comment.
I don't really like Log.error( e.getMessage(), e), as it'll lead to duplicate text in the error. Perhaps you should change e.getMessage() with a short text describing what the code failed to do.
There was a problem hiding this comment.
Ok, I changed exception for KeyStoreException and added message.
guusdk
reviewed
Aug 22, 2017
|
|
||
|
|
||
| private KeyStore trustStore, blackListStore, exceptionsStore; | ||
| public final static File TRUSTED = new File(Spark.getSparkUserHome() + File.separator + "security" + File.separator + "truststore"); |
There was a problem hiding this comment.
Please add in javadoc exactly what the purpose of every store is - so that Devs that look at this in the future understand how things are combined, and why.
There was a problem hiding this comment.
I added nice comment describing all Files/KeyStores
guusdk
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.