Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place config files in a versioned directory #1050

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel louise@openrobotics.org

🦟 Bug fix

Fixes #765

Summary

From Fortress, place the config files in a versioned directory inside ~/.ignition/gazebo. This will make sure that Fortress users don't reuse config files from older versions unless they explicitly ask to.

I targeted this at Fortress because I still haven't thought of a nice way to make this backwards compatible. The suggestion I put on the issue:

For example, Gazebo could always look for ~/.ignition/gazebo/gui.config first, and use that if it exists.

Wouldn't be a good idea for existing users who are migrating to Fortress, for example.

Checklist

  • Signed all commits for DCO
  • Added tests - existing tests should pass
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added bug Something isn't working beta Targeting beta release of upcoming collection labels Sep 24, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor comment

tutorials/resources.md Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1050 (6a3620c) into main (f4d47b5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 6a3620c differs from pull request most recent head bd35ed1. Consider uploading reports for the commit bd35ed1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1050      +/-   ##
==========================================
- Coverage   63.71%   63.70%   -0.01%     
==========================================
  Files         257      257              
  Lines       20064    20064              
==========================================
- Hits        12783    12782       -1     
- Misses       7281     7282       +1     
Impacted Files Coverage Δ
src/ServerConfig.cc 90.33% <100.00%> (ø)
src/gui/Gui.cc 64.34% <100.00%> (ø)
src/EntityComponentManager.cc 84.95% <0.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0381d...bd35ed1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants