Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DetachableJoint system: Add option to suppress warning about missing child model #132

Merged

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 11, 2020

This is useful for avoiding warning messages when parent and child models are spawned with a delay in between.

@azeey azeey requested a review from iche033 May 11, 2020 23:08
@azeey azeey requested a review from chapulina as a code owner May 11, 2020 23:08
@chapulina chapulina added the 📜 blueprint Ignition Blueprint label May 12, 2020
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just have same comment as Nate otherwise ready to approve

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey force-pushed the detachable_joint_suppress_warning branch from 3d1ce62 to 886fb16 Compare May 19, 2020 22:22
@azeey azeey merged commit 3ebdf5e into gazebosim:ign-gazebo2 May 19, 2020
azeey added a commit to azeey/gz-sim that referenced this pull request May 20, 2020
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
nkoenig added a commit that referenced this pull request May 21, 2020
* Add shapes plugin (#107)

Signed-off-by: John Shepherd <john@openrobotics.org>

* Add option to suppress warning about missing child model (#132)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Support multi entity spawn (#146)

* Support multi entity spawn

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Added more documentation

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: Nate Koenig <nate@openrobotics.org>

* Bump ign-msgs version to 4.9 (#148)

Signed-off-by: Louise Poubel <louise@openrobotics.org>

* Revert silly mistake

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* ign-msgs 5.3 dependency

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Bump minor version

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* Changelog

Signed-off-by: Nate Koenig <nate@openrobotics.org>

* RawPose

Signed-off-by: Nate Koenig <nate@openrobotics.org>

Co-authored-by: John <john@openrobotics.org>
Co-authored-by: Addisu Taddese <addisu@openrobotics.org>
Co-authored-by: Nate Koenig <nate@openrobotics.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@azeey azeey deleted the detachable_joint_suppress_warning branch May 22, 2020 02:02
azeey added a commit to azeey/gz-sim that referenced this pull request May 28, 2020
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants