Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blueprint] Add force focus when mouse enters render window #95

Merged
merged 5 commits into from
May 1, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Apr 25, 2020

Solves issue mentioned here.

This PR focuses the render window if the mouse enters it. Previously, the render window was only focused if the user clicked it, introducing a slightly annoying behavior where the user had to click twice in order to use the snapping behavior given the CTRL press wouldn't be registered until after the window was focused.

Signed-off-by: John Shepherd john@openrobotics.org

John Shepherd added 2 commits April 25, 2020 15:04
Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
@JShep1 JShep1 requested a review from chapulina April 25, 2020 22:29
Signed-off-by: John Shepherd <john@openrobotics.org>
@JShep1 JShep1 changed the title Add force focus when mouse enters render window [Blueprint] Add force focus when mouse enters render window Apr 27, 2020
@JShep1 JShep1 mentioned this pull request Apr 28, 2020
@iche033
Copy link
Contributor

iche033 commented Apr 28, 2020

update changelog please

Signed-off-by: John Shepherd <john@openrobotics.org>
Signed-off-by: John Shepherd <john@openrobotics.org>
@JShep1 JShep1 merged commit 9f913a2 into ign-gazebo2 May 1, 2020
@JShep1 JShep1 deleted the force_focus2 branch May 1, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants