Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if params of the Query is serizlized before key generation #156

Closed
igorkamyshev opened this issue Oct 28, 2022 · 0 comments · Fixed by #193
Closed

Check if params of the Query is serizlized before key generation #156

igorkamyshev opened this issue Oct 28, 2022 · 0 comments · Fixed by #193
Labels
scope:core type:enhancement New feature or request

Comments

@igorkamyshev
Copy link
Owner

Some tech debt was introduced in #131 🙃

Let's imagine:

const query = createQuery({ handler: (p) => null })

cache(query)

const someUnserializableData = /* ... */

query.start(someUnserializableData)

JSON.stringify(someUnserializableData) would be used as a part of a key, in some cases it could be unusful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:core type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant