-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache params ordering issue #193
Cache params ordering issue #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea 💙
However, I want to keep the core package with only one dependency — effector. So, I guess we can reimplement fast-json-stable-stringify
inside package.
Will close #156 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add changeset about fixes bug with un-serializable params? After that, we can ,erge it.
Co-authored-by: Igor Kamyşev <igor@kamyshev.me>
In the first commit, I represented the current problem with cache. Now, query params
{a: 1, b: 2}
and{b: 2, a: 1}
are resolved as different ones.In the second commit, I solved the problem with fast-json-stable-stringify library as an example. I'm opened to discussion: maybe we will find another solution or hardcode stable-json-hash inside core package.
fixes #156