Fix missing block when using valid? method

igorkasyanchuk · Oct 25, 2022 · 3204469 · 3204469
1 parent ed8efba
commit 3204469
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/active_storage_validations/metadata.rb b/lib/active_storage_validations/metadata.rb
@@ -90,7 +90,7 @@ def read_image
 
 
       raise InvalidImageError unless valid_image?(image)
-      yield image
+      yield image if block_given?
     rescue LoadError, NameError
       logger.info "Skipping image analysis because the mini_magick or ruby-vips gem isn't installed"
       {}

diff --git a/test/active_storage_validations_test.rb b/test/active_storage_validations_test.rb
@@ -282,6 +282,7 @@ class ActiveStorageValidations::Test < ActiveSupport::TestCase
     e = OnlyImage.new
     e.image.attach(image_1920x1080_file)
     e.proc_image.attach(image_1920x1080_file)
+    e.another_image.attach(image_1920x1080_file)
     assert e.valid?
 
     e = OnlyImage.new