New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

259 processable image validator matcher #262

Merged

Mth0158 merged 8 commits into igorkasyanchuk:master from Scorpahr:259-processable-image-validator-matcher

Sep 10, 2024

Contributor

Scorpahr commented Aug 16, 2024

Add matcher for processable_image + the test

Scorpahr added 3 commits

August 14, 2024 16:20


          processable image matcher

e7a8c6b


          change name of function

acdcf4d


          change order of function

e06b217

Mth0158 reviewed

View reviewed changes

lib/active_storage_validations/matchers/processable_image_validator_matcher.rb Outdated Show resolved Hide resolved

Mth0158 reviewed

View reviewed changes

lib/active_storage_validations/matchers/processable_image_validator_matcher.rb Outdated Show resolved Hide resolved

Mth0158 reviewed

View reviewed changes

lib/active_storage_validations/matchers/processable_image_validator_matcher.rb Outdated Show resolved Hide resolved

Mth0158 reviewed

View reviewed changes

test/matchers/processable_image_validator_matcher_test.rb Outdated Show resolved Hide resolved

Mth0158 reviewed

View reviewed changes

test/matchers/processable_image_validator_matcher_test.rb Outdated Show resolved Hide resolved

Mth0158 requested changes

View reviewed changes

Collaborator

Mth0158 left a comment

It is also missing code for:
checks_if_is_valid.rb
has_custom_matcher.rb

Scorpahr added 2 commits

August 26, 2024 10:57


          update code for has_custom_matcher.rb and checks_if_is_valid.rb

d4a4668


          update default of syntax

7afdb17

Mth0158 approved these changes

View reviewed changes

Mth0158 requested changes

View reviewed changes

Collaborator

Mth0158 left a comment

@Scorpahr could you make this last change, resolve the conflict (nice little exercise to do!) and then I'll merge it ;)
Good job for this 2nd PR!

lib/active_storage_validations/matchers/processable_image_validator_matcher.rb Outdated Show resolved Hide resolved

lib/active_storage_validations/matchers/processable_image_validator_matcher.rb Outdated Show resolved Hide resolved


          change code to keep DRY

f200f47

Mth0158 requested changes

View reviewed changes

lib/active_storage_validations/matchers/attached_validator_matcher.rb Outdated Show resolved Hide resolved

lib/active_storage_validations/matchers/attached_validator_matcher.rb Outdated Show resolved Hide resolved

lib/active_storage_validations/matchers/attached_validator_matcher.rb Outdated Show resolved Hide resolved

Scorpahr and others added 2 commits

September 10, 2024 13:30


          remove parameters that we don't need

67bd6cb


          Merge branch 'master' into 259-processable-image-validator-matcher

4a07678

Mth0158 approved these changes

View reviewed changes

Mth0158 merged commit 3729a2f into igorkasyanchuk:master

20 checks passed

Mth0158 mentioned this pull request

Matchers - Add processable_image_validatormatcher #257

Closed

fabn commented Oct 15, 2024

I'm testing this after library upgrade and the matcher fails because it search for public/image_1920x1080.png in my project root. Maybe you should use an embedded file instead of io: File.open(Rails.root.join('public', 'image_1920x1080.png'))?

Mth0158 mentioned this pull request

Processable image validator matcher fail #271

Closed

Collaborator

Mth0158 commented Oct 15, 2024

Hey @fabn
I am opening a new issue from your comment, it will be fixed soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet