fix 4.0.0v ransack #132
Merged
fix 4.0.0v ransack #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/rails_db/table.rb
Outdated
| @@ -60,6 +60,7 @@ def self.model_name | |||
| klass = ActiveRecord::Base.descendants.detect { |c| c.table_name == table_name } | |||
| end | |||
|
|
|||
| ransack_methods(klass) | |||
There was a problem hiding this comment.
- please rename to add_ransack_methods
- add a dependency in gemspec file to include ransack >= 4, this way it will require all developers to upgrade (OR to not make it so strict just add a check in the code if Ransack::VERSION >= 4.0 and then call this method)
There was a problem hiding this comment.
I like the if Ransack::VERSION >= 4.0, but got strange error NameError (uninitialized constant Ransack::VERSION).
So, I can get version in way like this
ransack_gem = Gem.loaded_specs['ransack']
add_ransack_methods(klass) if ransack_gem.version >= Gem::Version.new('4.0.0'). But not sure if it will be okay 👾👾👾
There was a problem hiding this comment.
I think this is good solution, as long specs are passed this is good for me
There was a problem hiding this comment.
@igorkasyanchuk fixed ( ˘▽˘)っ♨
|
@le-murier I think code is good enough to solve this issue, please check the comments |
|
@le-murier new version was released. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's looking a little bit ugly, but will allow all attributes and no association.
Pr for #131