Fix initialization and make "enabled" setting work

[haffla]

Hey!

I noticed that setting enabled to false actually doesn't work as expected. The problem is that when the engine code is executed the initializer hasn't even run yet, so RailsPerformance.enabled is always true.

Fixed it by delaying the middleware configuration using the "rails_performance.middleware" initializer.

Also replaced

• RailsPerformance.try(:enabled) with just RailsPerformance.enabled (why would the module not respond to enabled?)
• const_defined? with just defined? (I think it's the correct way to check if a gem is installed and has been required)

[haffla]

Hello @igorkasyanchuk

Did you get a chance to have a look at this?

[igorkasyanchuk]

Hi @haffla ,
sorry not enogh time

So as I see

rails_performance/app/controllers/rails_performance/rails_performance_controller.rb

Line 7 in 8c7f8a2

if RailsPerformance.enabled

this option is just disabling access to the admin panel.

And here:

rails_performance/lib/rails_performance/engine.rb

Line 10 in 8917f31

if RailsPerformance.try(:enabled) # for rails c

Have you created an initializer? Are you saying that this option if set to false in initialized later "true" in the code?

[haffla]

I am saying that testing for enabled inside of the Engine class (rails_performance/lib/rails_performance/engine.rb) does not work because when you start your Rails app, the Engine class is loaded before any of the Rails initializer files like config/initializers/rails_performance.rb are loaded. Just test it in your own app and set enabled to false. You will see that rails_performance is still collecting metrics because it is actually not disabled.

[igorkasyanchuk]

Ohh, I see. I thought I've tested and it was working. Good catch on this. Thanks

[igorkasyanchuk]

a new version was just released. Thanks for support