Fix navbar toggle #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, it's been a while, is it good? and could it be merge and release? |
|
Hi, oh :) yes, all is good, thank you for a reminder Just forgot about it. Will release later today |
|
Awesome, thanks ! 🥇 |
|
Successfully registered gem: rails_performance (1.0.2) Try this version and tell me if everything is OK |
|
Everything is OK, fix works like a charm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request fixes non-working navbar toggle by adding some javascript which toggle
is-activecss class on the burger and the menu when the burger is clicked.The javascript come from the Bulma documentation (see: https://bulma.io/documentation/components/navbar/#navbarJsExample)