Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where translations would go missing #71

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

Schlabbi
Copy link
Contributor

@Schlabbi Schlabbi commented Jan 15, 2020

This should fix #70.

Everytime a new translation key was added, the data of other recently added keys was accidentally overwritten in the data dict of the LocalizationsDataSource.

@Schlabbi Schlabbi requested a review from igorkulman as a code owner January 15, 2020 22:12
@igorkulman igorkulman self-assigned this Jan 16, 2020
@igorkulman igorkulman added the bug Something isn't working label Jan 16, 2020
@igorkulman
Copy link
Owner

Thanks!

@igorkulman igorkulman merged commit 09a8e83 into igorkulman:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App removes translations when adding a new key
2 participants