Fix free-before-use error

igrr · Feb 27, 2016 · b56cb4c · b56cb4c
1 parent f7f4719
commit b56cb4c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/espcomm/espcomm.c b/espcomm/espcomm.c
@@ -529,20 +529,22 @@ bool espcomm_upload_file(const char *name)
 
  size_t cb = fread(file_contents, 1, st.st_size, f);
  fclose(f);
- free(file_contents);
 
  if (cb != st.st_size)
  {
  LOGERR("failed to read file contents");
+ free(file_contents);
  return false;
  }
 
  if (!espcomm_upload_mem(file_contents, st.st_size))
  {
  LOGERR("espcomm_upload_mem failed");
+ free(file_contents);
  return false;
  }
 
+ free(file_contents);
  return true;
 }
 
@@ -671,4 +673,4 @@ bool espcomm_erase_flash()
  send_packet.checksum = 0;
  espcomm_send_command(RAM_DOWNLOAD_END, (unsigned char*) ram_packet, 8, 0);
  return true;
-}
+}