Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate "all" for single chromosome assemblies #236

Open
jrobinso opened this issue Dec 4, 2017 · 7 comments
Open

Eliminate "all" for single chromosome assemblies #236

jrobinso opened this issue Dec 4, 2017 · 7 comments
Assignees

Comments

@jrobinso
Copy link
Contributor

jrobinso commented Dec 4, 2017

In the special case of single chromosome assemblies, there is no difference in "All" and the chromosome. So for this case make 2 changes

(1) add the whole-genome resolution to the list of explicitly specified ones
(2) eliminate "All" from the chromosome pulldown menu

@jrobinso jrobinso self-assigned this Dec 4, 2017
@lidaof
Copy link

lidaof commented Oct 20, 2018

Hi @jrobinso , can I used 'all' in the 3rd parameter for straw API?
straw.getContactRecords(normalization,region1, 'all', units, binSize)?

tried, get a error with cannot getLength

@jrobinso
Copy link
Contributor Author

That is not correct syntax. The region argument is an object with chr, start, and end.

@jrobinso
Copy link
Contributor Author

The "all" query would not work even with correct syntax. I just pushed a fix for that, but the "region" arguments should look like this, do not specify start and end.

{
   chr: "ALL"
}

Also, do not specify a binSize, it is not relevant for "ALL". To use this you will need to pull and build (with grunt).

In the future please open a new issue for a new problem or question, this is not related to the original issue. It helps with tracking.

@jrobinso
Copy link
Contributor Author

BTW the "all" chromosome is used only for display, it is not really useful or suitable for analysis. The units are kb (not bp), and original chromosome information is lost.

@lidaof
Copy link

lidaof commented Oct 21, 2018

Thanks @jrobinso . I was thinking it's kinda related so didn't open a new issue.
From what you said, suppose I should not use 'all' to get all the interactions (in genome) with one region?

Currently what I am doing is put all chrom object (with chr, start, end) in an array and loop it with my single query region to get all interactions. That;s why I was asking if I can use all instead of a for loop.

Thanks again.

@jrobinso
Copy link
Contributor Author

It depends on what you are doing. If you are doing analysis I would not use "ALL", its is just used to get an approximate coarse scale view for visualization. You can't even know the bin size easily. If you want to paint a whole genome summary like juicebox does it is fine, but remember the coordinates are kilo-bases from the start of the first chromosome.

@lidaof
Copy link

lidaof commented Oct 22, 2018

@jrobinso Thank you so much for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants