Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added problem set template and bibliography statistics helpers #95

Merged
merged 66 commits into from
Aug 23, 2021
Merged

Conversation

BBieri
Copy link
Collaborator

@BBieri BBieri commented Aug 16, 2021

Description

Problem set template

Thesis

Package

Checklist:

  • PR form
    • I have given this pull request an informative title
    • Description above itemizes changes under subtitles, e.g. "## Collection""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
    • CodeFactor check: Package improves or maintains good style
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Any longer functions are commented inline so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

BBieri and others added 29 commits July 6, 2021 13:25
@BBieri BBieri requested a review from jhollway August 16, 2021 16:24
@BBieri
Copy link
Collaborator Author

BBieri commented Aug 17, 2021

PR is ready for your review @jhollway.

  • Note that I changed a bit how percent_female() works. I basically flattened the list of authors so as to deal with papers that have multiple authors.
  • Also note that there is still a remaining warning related to the absence of {genderdata} from the NAMESPACE when running devtools::check()

Copy link
Collaborator

@jhollway jhollway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting approach with the problem sets. Is that what you need for your courses?

DESCRIPTION Outdated Show resolved Hide resolved
DESCRIPTION Outdated Show resolved Hide resolved
DESCRIPTION Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/bibfix.R Show resolved Hide resolved
R/bibfix.R Show resolved Hide resolved
R/bibstats.R Outdated Show resolved Hide resolved
R/bibstats.R Show resolved Hide resolved
jhollway
jhollway previously approved these changes Aug 20, 2021
R/bibstats.R Outdated Show resolved Hide resolved
@BBieri
Copy link
Collaborator Author

BBieri commented Aug 20, 2021

Note to self: Update the bibstats test.

@BBieri BBieri mentioned this pull request Aug 21, 2021
@BBieri
Copy link
Collaborator Author

BBieri commented Aug 21, 2021

A bit about the reasoning behind the problem set template for posterity

Econ classes at the Institute require students to hand in around 4-5 problem sets per course in teams or individually. These problem sets either are in the traditional "math problem" format where we work on models or are data analysis focused (e.g. applied econometrics) which often use Stata. The workflow I used for the past year was to perform the data analysis in Stata, generate deliverables (graphs, tables) in Latex code with estout, and pasting them in a shared Latex project on Overleaf.

Since this year's classes will rely more on R, I thought it would be neat to have a template ready for the start of the semester. I'll also create a vignette exploring the collaboration tools that exist for R as I test them over the course of the semester.

Comment on lines +27 to +32
knit: iheiddown::problemset_pdf

#####################
## Output Options ##
#####################
output: iheiddown::problemset_pdf
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an error when I try and run this:

! Package fontspec Error: The font "Latin Modern Roman" cannot be found.

! kpathsea:make_tex: Invalid filename `Latin Modern Roman', contains ' '

Error: LaTeX failed to compile MINT001_ProblemSet_2021-08-21.tex. See https://yihui.org/tinytex/r/#debugging for debugging tips. See MINT001_ProblemSet_2021-08-21.log for more info.
Execution halted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! I have changed the fonts to be consistent with our thesis template and work via Latex packages rather than user system font imports. Could you confirm that it works now on macOS as well @jhollway ?

@BBieri BBieri merged commit 571af88 into main Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants