The boat wipes out part of the whirlpool when the hero who was in it disembarks

[oleg-derevenetz]

Preliminary checks

• I've checked that there aren't other open issues on the same topic.
• I've checked that this issue is reproducible on the latest snapshot build.

Platform

Windows

Describe the bug

Found during testing #9140. On the master branch:

fheroes2.engine.version_.1.1.2.2024-09-25.00-41-01.mp4

After the hero disembarks from a boat located on one of the tiles of the whirlpool, the OBJ_BOAT replaces the OBJ_WHIRLPOOL on that tile. On the master branch, another hero is still able to teleport to that tile with the OBJ_BOAT. If the hero gets back into the boat and sails away from the whirlpool, the whirlpool object on that tile is not being restored, but another hero still can teleport to it:

fheroes2.engine.version_.1.1.2.2024-09-25.00-41-36.mp4

With the fixes from #9140, the situation is a little different - OBJ_BOAT still replaces the OBJ_WHIRLPOOL upon disembarking, but another hero cannot teleport to that tile anymore (regardless of whether it's occupied with the boat or not):

fheroes2.engine.version_.1.1.2.2024-09-25.00-54-38.mp4

Save file

Test map:

!!TEST1.zip

Additional info

No response

[oleg-derevenetz]

Hi @ihhub none of my PRs are intended to fix this :) This is not a pathfinder issue, but rather an issue related to map internals, as I see it, since a map tile is not able to hold two objects at the same time (just like that issue with a pickupable object on a coast). I would like to suggest someone who understands the map internals to take a look.