Speed up getting a list of files on PS Vita

[oleg-derevenetz]

fix #9309

• Don't try to find the actual case-sensitive path using its case-insensitive variant;
• Use the native filesystem API to get the list of files in a directory instead of std::filesystem::directory_iterator;
• Place the fheroes2 version info into the param.sfo;
• Optimize the ListFiles::FindFileInDir().

[Districh-ru]

The last commits show New Game menu load speed-up: about 560 ms on Vita3K emulator. It is faster than master build (~850 ms), but a little slower than v.1.1.2 (~350 ms).

[oleg-derevenetz]

The last commits show New Game menu load speed-up: about 560 ms on Vita3K emulator. It is faster than master build (~850 ms), but a little slower than v.1.1.2 (~350 ms).

Well, we also can make a "special case" for System::IsFile() and System::isDirectory(), but originally on PS Vita they didn't verify that the given name is really a file or a directory, they only verified that the file with the given name exists. Now it is all verified.

[Districh-ru]

I've asked Pønytail on Discord to test the new build when he have time. I've added the load time estimation to the New Game menu:

    fheroes2::Time counter;
    counter.reset();
    
    // Code to estimate execution time.

    const double timeMs = counter.getS() * 1000;
    fheroes2::showStandardTextMessage( "Time for menu", std::to_string( timeMs ) + " ms.", Dialog::OK );

Lets check the real hardware. If the load time of New Game is normal (less then a couple of seconds) then it is better to keep file verification in cost of some commutation time.

[Districh-ru]

The 99e4c1e commit has almost no affect on menu load speed on Vita3K emulator. It is about 560 ms.

[oleg-derevenetz]

The 99e4c1e commit has almost no affect on menu load speed on Vita3K emulator. It is about 560 ms.

Well, if it doesn't give anything on a real device as well, it would be better to roll it back. The less "special" code, the better.

[Districh-ru]

Well, if it doesn't give anything on a real device as well, it would be better to roll it back. The less "special" code, the better.

I've asked Pønytail to test this change as well. Let's wait for his response on Discord (most probably tomorrow).

[Districh-ru]

Pønytail reported that both versions (with 99e4c1e and without it) act the same and are close to v 1.1.2:

Попробовал обе версии! Отклик "новой игры" 430мс, отклик "обычной игры" 56с. Результат аналогичный версии 1.1.2.

So we can revert the last commit since it has no benefits.

Since we are updating PS Vita related code we could also properly show version number in PS Vita by updating the Makefile.vita file.
Add after line 31:
PROJECT_VERSION := $(file < version.txt)
and update line 59:
vita-mksfoex -s TITLE_ID="$(PROJECT_TITLEID)" -s APP_VER="$(PROJECT_VERSION)" "$(PROJECT_TITLE)" param.sfo

Currently it is always 0.00

What do you think, @oleg-derevenetz ?

[Districh-ru]

Tested with Vita3K emulator - New Game menu load time is OK (~550 ms).

[ihhub]

@oleg-derevenetz , many thanks for this fix!