Skip to content

Conversation

@sjvanrossum
Copy link

@sjvanrossum sjvanrossum commented Jun 20, 2024

Adds missing changes to apache#31608, may need additional tests for coverage.
Tested in Dataflow against Pub/Sub for e2e validation.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@sjvanrossum
Copy link
Author

R: @iht

@iht iht merged commit 2b71e10 into iht:r256pr31608 Jun 20, 2024
@iht
Copy link
Owner

iht commented Jun 20, 2024

Thanks!! @sjvanrossum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants