Add gcages package #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
No data in outputs_dir=WindowsPath('C:/Users/kikstra/Documents/GitHub/emissions_harmonization_historical/data/global/wmo-2022/data_raw/README.md/outputs') is expected
Updates following review
Suggestions for harmonisation PR
Harmonisation
jkikstra
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
All tests are working on my computer.
This could definitely benefit from a bit more installation instructions for Windows. (requires installing uv [e.g. through pip or pipx] first, and then to run the necessary uv command) and would also be nice to provide a pointer to how to run the tests.
But let's just go ahead for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adds the package. Run the tests if you want.