Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pin of outdated R version #545

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Remove pin of outdated R version #545

merged 1 commit into from
Sep 25, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Sep 25, 2024

Today, I was reminded of #479, which recorded some problem of possibly interfering versions 4.2.3 and 4.3.0 of R in our CI test suite. These were encountered in #478, which introduced a workaround by pinning to 4.2.3.

The current release is 4.4.1, so this workaround/pin might be outdated. This PR tries removing the pin to see if our test suite is still working fine with the latest version of R.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update tests setup
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update release notes. Just CI.

@glatterf42 glatterf42 added enh New features & functionality ci Continuous integration labels Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (080ad2b) to head (d3b366c).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #545     +/-   ##
=======================================
+ Coverage   98.8%   98.9%   +0.1%     
=======================================
  Files         44      44             
  Lines       4819    4819             
=======================================
+ Hits        4765    4770      +5     
+ Misses        54      49      -5     

see 2 files with indirect coverage changes

@glatterf42 glatterf42 self-assigned this Sep 25, 2024
@glatterf42 glatterf42 linked an issue Sep 25, 2024 that may be closed by this pull request
@glatterf42 glatterf42 requested a review from khaeru September 25, 2024 11:51
@glatterf42
Copy link
Member Author

This is working for now, it seems; let's see if it re-introduces some flakiness.

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For completeness, I updated the PR description to mention the original PR that introduced the pin.

@glatterf42 glatterf42 merged commit c49a115 into main Sep 25, 2024
21 checks passed
@glatterf42 glatterf42 deleted the enh/remove-r-ci-pin branch September 25, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R 4.3.0 not working as expected on macOS
2 participants