Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 to supported versions #16

Merged
merged 8 commits into from
Sep 6, 2023

Conversation

danielhuppmann
Copy link
Member

Add Python 3.11 to supported versions

@danielhuppmann
Copy link
Member Author

Ok, I have no idea why this PR is failing... Please help @meksor @phackstock @glatterf42!

@meksor
Copy link
Contributor

meksor commented Sep 4, 2023

My first guess: we might need the package python3.11-dev in the container used to run these checks.

@phackstock
Copy link
Contributor

@meksor, seems like you're onto something aio-libs/aiohttp#6600 (comment).

@phackstock
Copy link
Contributor

Installing python3.11-dev does not seem to be the solution... I'll keep on digging.

@phackstock
Copy link
Contributor

@danielhuppmann, tests are finally running now.
After some painful debugging I was able to fix it.
The issue seems to have been a package called httptools which is a dependency of the uvicorn package.
uvicorn was pinned to an outdated version ^0.15, I now updated it to the closest version that fixed the install which turned out to be 0.17.

@phackstock
Copy link
Contributor

Let's see if the tests run through. If they do I guess we can go ahead with the merge, fix the conda publishing and then release v0.3.1.

Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR since the tests are passing.

@danielhuppmann danielhuppmann merged commit a9f8adf into iiasa:main Sep 6, 2023
4 checks passed
@danielhuppmann danielhuppmann deleted the devops/py3.11 branch September 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants