Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A tutorial for adding an upper bound on investment #602

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

behnam-zakeri
Copy link
Contributor

@behnam-zakeri behnam-zakeri commented May 10, 2022

This PR is to demonstrate how GAMS files can be changed for adding a new variable or parameter. This was part of the hands-on session of the MESSAGEix Community meeting 2022.

Notice: This PR does not need to be merged, because the changes made in the GAMS file here are intended to be only for demonstration.

How to review

Switch to this branch and run the accompanying tutorial. It should run and solve successfully (no errors and unfeasibility, otherwise stated in the tutorial). Please make sure the text in the tutorial is clear and understandable.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅ (the tutorial is being tested in test_tutorials.py)
  • Add, expand, or update documentation. (the tutorial should have the required documentation).
  • Update release notes.

@khaeru
Copy link
Member

khaeru commented May 10, 2022

Thanks for this contribution! FYI, you can:

  • Click on the top right where it says "Still in progress? Convert to draft"
  • Remove the text "[WIP] " from the title.

The draft status conveys clearly that this is work in progress.

Please also:

  • Assign yourself and anyone else who will complete the PR.
  • Add it to "MESSAGEix team" under "Projects".

@behnam-zakeri behnam-zakeri self-assigned this May 10, 2022
@behnam-zakeri behnam-zakeri changed the title [WIP] A tutorial for adding an upper bound on investment A tutorial for adding an upper bound on investment May 10, 2022
@behnam-zakeri behnam-zakeri marked this pull request as draft July 18, 2022 12:20
@behnam-zakeri behnam-zakeri added enh New features & functionality docs Documentation labels Jul 18, 2022
@behnam-zakeri behnam-zakeri marked this pull request as ready for review December 12, 2022 12:37
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.5%. Comparing base (3b6651f) to head (5f1bb83).
Report is 472 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #602   +/-   ##
=====================================
  Coverage   93.5%   93.5%           
=====================================
  Files         44      44           
  Lines       3511    3511           
=====================================
  Hits        3283    3283           
  Misses       228     228           

see 2 files with indirect coverage changes

@behnam-zakeri behnam-zakeri marked this pull request as draft December 12, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants