-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop outdated pin of JPype on CI #880
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=====================================
Coverage 95.5% 95.5%
=====================================
Files 46 46
Lines 4340 4340
=====================================
Hits 4148 4148
Misses 192 192 |
Rather than “we can probably drop testing [3.8]”, it is our versioning policy to drop support for EOL Pythons and add support for new ones ASAP. This made me check and realize that we don't yet have a PR on message_ix parallel to iiasa/ixmp#544. Is it possible to expand this one to include parallel changes? |
True, good catch. Most of the required changes should be here now :) |
The current failures arise from failing to build Python-3.13 wheels for pyarrow, which should be fixed once they release v18.0.0, but this has yet to happen. |
f132d32
to
346a2d9
Compare
346a2d9
to
e461bca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, including a rebase to drop the "TEMPORARY" commit.
e461bca
to
c0356b6
Compare
Today's CI failures somewhat irritate me since we install anaconda and miniconda versions for Python 3.10, and
conda info
even shows this, butmessage-ix show-versions
then shows that Python version 3.8.20 is used. 3.8 has just reached its end of life, so we can probably drop testing it and the main difference to the runs using newer versions is the pin of JPype 1.2.1.This version was released almost four years ago now (4.1.2021), so I think it's safe to remove this pin entirely rather than trying to debug the action.
How to review
Please note: this PR contains one commit that temporarily enables the action for this PR; that should be dropped before merging.
PR checklist
[ ] Add or expand tests; coverage checks both ✅Just CI update.[ ] Add, expand, or update documentation.Just CI update.[ ] Update release notes.Just CI update.