-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs with links and a new paper #888
Update docs with links and a new paper #888
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #888 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 48 48
Lines 4394 4394
=====================================
Hits 4204 4204
Misses 190 190 |
fac4740
to
1653084
Compare
Hi Fridolin,
Nice to hear from you.
I'm sending attached some suggestions of images. Please feel free to use
the most suitable one.
Here is the link for the paper:
https://www.sciencedirect.com/science/article/pii/S2352152X2400834X#f0010
Let me know if you need any extra info.
Best,
Natalia
[image: SPHS.jpg][image: BESSM model overview.jpg][image: BESSM
model.jpg][image:
Methodology.jpg]
…On Wed, Nov 13, 2024 at 2:38 PM Fridolin Glatter ***@***.***> wrote:
Thanks to @shreeyashn20 <https://github.com/shreeyashn20> in #883
<#883>, I have been made
aware of the paper
<https://www.sciencedirect.com/science/article/pii/S2352152X2400834X> by
@natiweber <https://github.com/natiweber> about the Brazilian energy
model with seasonal pumped hydropower storage. This PR adds a link to that
to the docs.
It also links our new community health files from our contributing page.
@natiweber <https://github.com/natiweber> or @behnam-zakeri
<https://github.com/behnam-zakeri> (since you are a co-author): we
usually use a preview image for the entries on our usage page. Please let
me know if you have an image in mind that we can use for that :)
How to review
- Read the diff and note that the CI checks all pass.
- Look at the pages in the docs that changed and confirm they look
good:
- TBD
PR checklist
- Continuous integration checks all ✅
- [ ] Add or expand tests; coverage checks both ✅ Just updating docs.
- Add, expand, or update documentation.
- [ ] Update release notes. Just updating docs.
------------------------------
You can view, comment on, or merge this pull request online at:
#888
Commit Summary
- 827accf
<827accf>
Add new paper to bibliography
- c50d010
<c50d010>
Add paragraph about new paper to docs
- fac4740
<fac4740>
Add links to community health files to contributing page
File Changes
(3 files <https://github.com/iiasa/message_ix/pull/888/files>)
- *M* doc/contributing.rst
<https://github.com/iiasa/message_ix/pull/888/files#diff-13795c17121ec235cc0d7a1f5df177f3a5af2e32d2cbd2d95c8b020ad8c76516>
(5)
- *M* doc/references.bib
<https://github.com/iiasa/message_ix/pull/888/files#diff-377b988b90a7f40ae57540205224bac7050f568f9a76c518e20e76e899134655>
(14)
- *M* doc/usage.rst
<https://github.com/iiasa/message_ix/pull/888/files#diff-e2f32bf1fe37315337b25b0d5efe2a8dde59b0f5ea2c3d6fddcf3f8b6d0fe9d1>
(15)
Patch Links:
- https://github.com/iiasa/message_ix/pull/888.patch
- https://github.com/iiasa/message_ix/pull/888.diff
—
Reply to this email directly, view it on GitHub
<#888>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUUQ37UKOLR2FMRX4UYLQT2ANI5FAVCNFSM6AAAAABRWQNS2WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TKNJVGY3DINQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Natalia Weber, Dr. Ing.*
Mentoring Programme Coordinator
📞 +43 676 551 3831
🌐 LinkedIn <http://www.linkedin.com/in/natalia-ab-weber>
|
1653084
to
0d65d2d
Compare
Thanks for the suggestions, let's see how we like the one I used now :) |
0d65d2d
to
2181059
Compare
2181059
to
6fd03a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this as we would like to include this in the showcase of MESSAGE applications for the 3.10 release, which is already a little delayed.
@behnam-zakeri @natiweber if you have any objections to the image that @glatterf42 has picked out here, please let us know by end-of-day. If you don't manage to look at it, also no problem; we can make another PR to swap out the image for a different one.
Hir Paul,
Thank you for the update. I have no objections to the image selected by
@glatterf42. Thank you for checking :)
Best,
Natalia
…On Mon, Feb 3, 2025 at 10:42 AM Paul Natsuo Kishimoto < ***@***.***> wrote:
***@***.**** approved this pull request.
I am approving this as we would like to include this in the showcase of
MESSAGE applications for the 3.10 release, which is already a little
delayed.
@behnam-zakeri <https://github.com/behnam-zakeri> @natiweber
<https://github.com/natiweber> if you have any objections to the image
that @glatterf42 <https://github.com/glatterf42> has picked out here,
please let us know by end-of-day. If you don't manage to look at it, also
no problem; we can make another PR to swap out the image for a different
one.
—
Reply to this email directly, view it on GitHub
<#888 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANUUQ37DLGTXANOOXPRDQM32N42XVAVCNFSM6AAAAABRWQNS2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBZGM4DKNBTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Natalia Weber, Dr. Ing.*
Mentoring Programme Coordinator
📞 +43 676 551 3831
🌐 LinkedIn <http://www.linkedin.com/in/natalia-ab-weber>
|
Great, thanks! |
Thanks to @shreeyashn20 in #883, I have been made aware of the paper by @natiweber about the Brazilian energy model with seasonal pumped hydropower storage. This PR adds a link to that to the docs.
It also links our new community health files from our contributing page.
@natiweber or @behnam-zakeri (since you are a co-author): we usually use a preview image for the entries on our usage page. Please let me know if you have an image in mind that we can use for that :)
How to review
PR checklist
[ ] Add or expand tests; coverage checks both ✅Just updating docs.[ ] Update release notes.Just updating docs.