Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The screen automatically dims when playing #3880

Closed
ryan-si opened this issue Jul 19, 2022 · 19 comments
Closed

The screen automatically dims when playing #3880

ryan-si opened this issue Jul 19, 2022 · 19 comments

Comments

@ryan-si
Copy link

ryan-si commented Jul 19, 2022

System and IINA version: macOS 13.0 iina 1.3.0

Expected behavior:
The screen should keep its brightness level.

Actual behavior:
When playing HDR video, the screen automatically dims when the mouse stops moving.

Steps to reproduce:
Paly an HDR video on MacBook Pro 14 inch's screen.

How often does this happen?
everytime

@low-batt
Copy link
Contributor

You are experiencing this running the macOS Ventura (13.0) public beta?

If so, I suggest reporting this behavior to Apple. See this iMore article: How to send feedback to Apple about macOS betas

@ryan-si
Copy link
Author

ryan-si commented Jul 19, 2022

You are experiencing this running the macOS Ventura (13.0) public beta?

If so, I suggest reporting this behavior to Apple. See this iMore article: How to send feedback to Apple about macOS betas

Yes, that's happening on macOS Ventura. OK, I'll report to Apple. Thank you.

@low-batt
Copy link
Contributor

Thanks! Please let us know what Apple as to say.

One possibility is that this macOS feature is malfunctioning in Ventura:
If the brightness is limited on your MacBook Pro with Liquid Retina XDR display or Apple Pro Display XDR

Hopefully Apple will explain the behavior.

@poorest1212
Copy link

beta2 still sucks... cannot watch HDR video in fullscreen, only works in window mode

@low-batt
Copy link
Contributor

low-batt commented Aug 1, 2022

Thank you for reporting this. It is helpful for the IINA project to know that there is trouble when running under the Ventura Public Beta. However the point of macOS Beta releases is for Apple to gather feedback. Have you reported this behavior to Apple as well? From Apple Beta Software Program FAQ:

How do I provide my feedback to Apple?

The iOS, iPadOS and macOS public betas come with the built-in Feedback Assistant app, which can be opened from the Home screen on your iPhone or iPad or from the Dock on your Mac. The Feedback Assistant app is also available from the help menu of any app by selecting Send Feedback. If you’re running the tvOS, HomePod software or watchOS public beta, you can submit feedback through the Feedback Assistant app on an enrolled iPhone, iPad or Mac. When you experience an issue or something does not work as expected, send your feedback directly to Apple with Feedback Assistant.

Ventura Beta 2 was mentioned. Beta 4 is out. Definitely upgrade and see if Apple has fixed this. Apply may not have as I did not find anything that could explain this behavior in the macOS 13 Ventura Beta 4 Release Notes.

What you are reporting seems to be slightly different from the first report which is reporting dimming when "when the mouse stops moving". Your report seems to have to do with "full screen"? Does dimming stop when in full screen and you move the mouse? Are you also using one of the new MacBook Pro's with the XDR display?

This is not my area of expertise, but here are some thoughts anyway...

First, watch out for IINA's HDR issue where it randomly fails to enable HDR. You can tell if IINA enabled HDR by looking at the Quick Settings Panel for video. This is expected to be fixed in the next release of IINA.

IINA has two forms of full screen. Under Preferences..., General, Behavior look for the checkbox Use legacy full screen. Does changing that preference change the dimming behavior?

Make certain this feature is not triggering: If the brightness is limited on your MacBook Pro with Liquid Retina XDR display or Apple Pro Display XDR. Confirm you do not see the warning symbol shown in that article.

There are two macOS preferences that I know of which control screen brightness. At least that is how it is in Monterey. This preference: Change your Mac display’s brightness. And this preference: Change Battery preferences on a Mac notebook. In Monterey this looks like:
issue-3880-displays

And:
issue-3880-battery

Does turning off these preferences make a difference in the case at hand?

@ryan-si
Copy link
Author

ryan-si commented Aug 2, 2022

Thank you for reporting this. It is helpful for the IINA project to know that there is trouble when running under the Ventura Public Beta. However the point of macOS Beta releases is for Apple to gather feedback. Have you reported this behavior to Apple as well? From Apple Beta Software Program FAQ:

How do I provide my feedback to Apple?
The iOS, iPadOS and macOS public betas come with the built-in Feedback Assistant app, which can be opened from the Home screen on your iPhone or iPad or from the Dock on your Mac. The Feedback Assistant app is also available from the help menu of any app by selecting Send Feedback. If you’re running the tvOS, HomePod software or watchOS public beta, you can submit feedback through the Feedback Assistant app on an enrolled iPhone, iPad or Mac. When you experience an issue or something does not work as expected, send your feedback directly to Apple with Feedback Assistant.

Ventura Beta 2 was mentioned. Beta 4 is out. Definitely upgrade and see if Apple has fixed this. Apply may not have as I did not find anything that could explain this behavior in the macOS 13 Ventura Beta 4 Release Notes.

What you are reporting seems to be slightly different from the first report which is reporting dimming when "when the mouse stops moving". Your report seems to have to do with "full screen"? Does dimming stop when in full screen and you move the mouse? Are you also using one of the new MacBook Pro's with the XDR display?

This is not my area of expertise, but here are some thoughts anyway...

First, watch out for IINA's HDR issue where it randomly fails to enable HDR. You can tell if IINA enabled HDR by looking at the Quick Settings Panel for video. This is expected to be fixed in the next release of IINA.

IINA has two forms of full screen. Under Preferences..., General, Behavior look for the checkbox Use legacy full screen. Does changing that preference change the dimming behavior?

Make certain this feature is not triggering: If the brightness is limited on your MacBook Pro with Liquid Retina XDR display or Apple Pro Display XDR. Confirm you do not see the warning symbol shown in that article.

There are two macOS preferences that I know of which control screen brightness. At least that is how it is in Monterey. This preference: Change your Mac display’s brightness. And this preference: Change Battery preferences on a Mac notebook. In Monterey this looks like: issue-3880-displays

And: issue-3880-battery

Does turning off these preferences make a difference in the case at hand?

Yes. My situation is when I turn "full screen" and the mouse stops moving, the screen dims. And this problem only happens when I play the video, if I pause the HDR video, the screen does not dim.

Are you also using one of the new MacBook Pro's with the XDR display? Yes, my model is Macbook Pro 14 inch.

IINA has two forms of full screen. Under Preferences..., General, Behavior look for the checkbox Use legacy full screen. Does changing that preference change the dimming behavior?
No, can not fix the problem.

Confirm you do not see the warning symbol shown in that article.
Also, not.

Automatically adjust brightness True Tone: Turning off these options does not fix the problem.

I try to feedback to Apple, but they do not give me any response.

@low-batt
Copy link
Contributor

low-batt commented Aug 2, 2022

@HurstSi Thanks for the update. Some of my questions were directed at @poorest1212 whose report did not mention the type of Mac and other details.

Good that you filed a report. The more an issue is reported the more likely it is that Apple will look into it.

The tests you ran ruled out a bunch of possibilities. Unfortunately that leaves us waiting to hear from Apple.

@cyoumatsu
Copy link

I don't know English very well, but I found a solution in the iina settings and it doesn't affect the viewing experience.

Preferences--->User Interface--->OSD--->Display system time and battery in full screen.

Can solve the problem of sudden darkening of full-screen HDR video playback.

@low-batt
Copy link
Contributor

low-batt commented Aug 4, 2022

@CarterLi, any ideas on this issue?

@CarterLi
Copy link
Contributor

CarterLi commented Aug 4, 2022

Seems to be a system bug. OSD should not affect HDR modes whatsoever

@yay
Copy link

yay commented Aug 14, 2022

Same issue here. m1 pro macbook, macOS 13.0 beta 5, iina 1.3.0, playing 8K HDR video on external monitor (Apple Studio Display).

@gorgepawns-0c
Copy link

Found a solution under preferences>advanced>use mpv OSD. It helped.

@manancodes
Copy link

I had a similar problem in MacOS Ventura and this solved the problem for me.

Go to Settings > Display > Advanced
Disable Slightly dim the display on battery

Screenshot 2022-09-21 at 8 08 07 PM

This was under battery settings in the previous MacOS versions.

@prakashvis
Copy link

prakashvis commented Oct 26, 2022

This is issue still exist in Ventura stable build. Looks like Apple didn't fix it.

I tried both mpv osd and disabling dimming in battery settings and display settings. Nothing works as of now.

@poorest1212
Copy link

Same here, really really annoying. I've fedback an issue to Apple public beta, provided further information required by Apple, but still no update yet

@shen04
Copy link

shen04 commented Oct 26, 2022

Also having this issue. MacOS 13.0 (22A380).

@low-batt
Copy link
Contributor

I have upgraded to Ventura. The problem reproduced for me. Playing the same HDR test file that was working fine under Monterey results in an image that is so dark it is hard to see anything under Ventura.

Investigating...

@low-batt
Copy link
Contributor

low-batt commented Nov 3, 2022

This same problem is reported in multiple issues. Closing duplicates in favor of the first report of this problem in issue #3844.

@low-batt low-batt closed this as completed Nov 3, 2022
low-batt pushed a commit that referenced this issue Nov 3, 2022
This workaround also addresses another macOS Ventura regression where
an external monitor goes black, #4015.

This same dimming problem was reported in issues #3880, #4013 and #4014.

The workaround changes the windowDidLoad method of MainWindowController
such that when running under macOS Ventura it will add a tiny subview
with such a low alpha level it is invisible to the human eye.

Issue #4015 has been reproduced without IINA, so we are certain this is
a regression in macOS 13. At this time we do not know the root cause and
can not explain why this workaround works.
low-batt added a commit that referenced this issue Nov 3, 2022
This workaround also addresses another macOS Ventura regression where an
external monitor goes black, #4015.

This same dimming problem was reported in issues #3880, #4013 and #4014.

The workaround changes the windowDidLoad method of MainWindowController
such that when running under macOS Ventura it will add a tiny subview
with such a low alpha level it is invisible to the human eye.

Issue #4015 has been reproduced without IINA, so we are certain this is
a regression in macOS 13. At this time we do not know the root cause and
can not explain why this workaround works. This workaround may not be
effective in all cases.
uiryuu pushed a commit that referenced this issue Nov 3, 2022
This workaround also addresses another macOS Ventura regression where
an external monitor goes black, #4015.

This same dimming problem was reported in issues #3880, #4013 and #4014.

The workaround changes the windowDidLoad method of MainWindowController
such that when running under macOS Ventura it will add a tiny subview
with such a low alpha level it is invisible to the human eye.

Issue #4015 has been reproduced without IINA, so we are certain this is
a regression in macOS 13. At this time we do not know the root cause and
can not explain why this workaround works.
uiryuu pushed a commit that referenced this issue Nov 3, 2022
This workaround also addresses another macOS Ventura regression where an
external monitor goes black, #4015.

This same dimming problem was reported in issues #3880, #4013 and #4014.

The workaround changes the windowDidLoad method of MainWindowController
such that when running under macOS Ventura it will add a tiny subview
with such a low alpha level it is invisible to the human eye.

Issue #4015 has been reproduced without IINA, so we are certain this is
a regression in macOS 13. At this time we do not know the root cause and
can not explain why this workaround works. This workaround may not be
effective in all cases.
@sawtoothpuma
Copy link

It doesn't matter if the source is HDR or SDR. When I viewing a image/video that gets to a dark scene or black background, the screen dims slowly, even with all the auto brightness settings turned off. It usually happens while I'm in fullscreen. I was able to recreate this by viewing a black background video on YouTube, and the only way to fix it was to decrease the brightness and then turn it back up. Shouldn't have to do this, it's really annoying!

Anyone found a fix for this yet? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.