Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unix specific TMP-paths #172

Closed
RogerMathisen opened this issue Sep 24, 2014 · 2 comments
Closed

Unix specific TMP-paths #172

RogerMathisen opened this issue Sep 24, 2014 · 2 comments
Labels
bug
Milestone
2.1.0 Minor Release

Comments

@RogerMathisen
Copy link
Contributor

Some classes and test classes have references to Unix specific TMP-path, which will make them fail under Windows.

org.archive.wayback.liveweb.URLtoARCCacher
The variable "DEFAULT_RECORDER_DIR" will not be valid under Windows.

org.archive.wayback.util.MonitoredFileSetTest
The File variables "f1" and "f2" will not be valid.

org.archive.wayback.accesscontrol.ExternalExcluderTest
The variable "configPath" is not valid under Windows, but is never used so the test does not fail.

Also
org.archive.wayback.resourceindex.cdxserver.EmbeddedCDXServerIndexTest
Fails because of CRLF differences on Windows and Unix comparing against "\n". This should be
investigated further to be sure that the actual class does not have the same problem.
@kris-sigur
Copy link
Member

Yes, these instances should all be rewritten to use System.getProperty("java.io.tmpdir")

@johnerikhalse johnerikhalse added this to the 2.0.1 Release milestone Sep 30, 2014
RogerMathisen added a commit to nlnwa/openwayback that referenced this issue Nov 5, 2014
@RogerMathisen
Issue iipc#172
9b64163 
- Removed all direct references to /tmp and /var/tmp in the code, as it will not work on Windows OS.
@RogerMathisen RogerMathisen mentioned this issue Nov 5, 2014
Merged
@PsypherPunk
Copy link
Contributor

Fixed in 0ad526a.

kngenie added a commit to kngenie/wayback that referenced this issue Feb 14, 2020
@kngenie
Merge pull request iipc#172 from kngenie/extensible-cdx-format
8293bce 
Refactoring CDXServer processor code for coming extension of CDX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1.0 Minor Release
Development

No branches or pull requests
4 participants
@PsypherPunk @kris-sigur @johnerikhalse @RogerMathisen