Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging-config-path and config-path must be absolute on Tomcat 8 #196

Closed
dmolesUC opened this issue Jan 15, 2015 · 5 comments
Closed

logging-config-path and config-path must be absolute on Tomcat 8 #196

dmolesUC opened this issue Jan 15, 2015 · 5 comments

Comments

@dmolesUC
Copy link
Contributor

In order to get OpenWayback 2.0.0 up and running under Tomcat 8.0.15 / Oracle JDK 8 / Mac OS 10.10, I had to change the default logging-config-path and config-path from relative to absolute paths:

    <context-param>
        <param-name>logging-config-path</param-name>
        <!-- <param-value>WEB-INF/classes/logging.properties</param-value> -->
        <param-value>/WEB-INF/classes/logging.properties</param-value>
    </context-param>
    <context-param>
        <param-name>config-path</param-name>
        <!-- <param-value>WEB-INF/wayback.xml</param-value> -->
        <param-value>/WEB-INF/wayback.xml</param-value>
    </context-param>

This looks to be a Tomcat issue, as org.apache.catalina.webresources.StandardRoot.validate(String) has a path.startsWith("/") check.

@dmolesUC dmolesUC changed the title logging-config-path and config-path must be absolute on Tomcat 8 under Mac OS 10.10 logging-config-path and config-path must be absolute on Tomcat 8, Java 8, Mac OS 10.10 Jan 15, 2015
@dmolesUC dmolesUC changed the title logging-config-path and config-path must be absolute on Tomcat 8, Java 8, Mac OS 10.10 logging-config-path and config-path must be absolute on Tomcat 8 Jan 15, 2015
@anjackson
Copy link
Member

Can I assume this syntax will work under Tomcat 6/7 as well as 8?

@dmolesUC
Copy link
Contributor Author

I've only got 8 on this box, so I don't know for sure. If you have a Tomcat 6/7 setup handy (surely somebody in this room does?), give it a try. :)

@PsypherPunk
Copy link
Contributor

Tried this in Tomcat 7 (Windows) and it still works as expected.

@anjackson
Copy link
Member

Cool, can you turn that into a pull request? Note that I've just synced up the ukwa fork so you'll need to update first.

@dmolesUC
Copy link
Contributor Author

Done!

@kris-sigur kris-sigur added this to the 2.0.1 Bugfix Release milestone Feb 2, 2015
kris-sigur pushed a commit that referenced this issue Feb 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants