Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: testPadDateStr(org.archive.wayback.util.TimestampTest): padEnd expected:<...28...> but was:<...31...> #231

Closed
rossh opened this issue Mar 30, 2015 · 1 comment
Closed

Failing test: testPadDateStr(org.archive.wayback.util.TimestampTest): padEnd expected:<...28...> but was:<...31...> #231

rossh opened this issue Mar 30, 2015 · 1 comment
Milestone
2.2.0 Minor Release

Comments

@rossh
Copy link
Contributor

rossh commented Mar 30, 2015

Hi guys, I'm getting the following test failure:

Failed tests: testPadDateStr(org.archive.wayback.util.TimestampTest): padEnd expected:<...28...> but was:<...31...>

This is happening because Timestamp.getDaysInMonthBound has a bug in it which doesn't return back the correct maximum day of the month for months which don't have a 29th, 30th and 31st e.g. February. We've fixed it and will do a pull request.
@rossh rossh mentioned this issue Mar 30, 2015
Closed
@kris-sigur kris-sigur added this to the 2.2.0 Minor Release milestone Mar 30, 2015
@kris-sigur
Copy link
Member

This is a naughty little bug. Thanks for tracking it down. I'll see about getting this merged later today.

kris-sigur added a commit to kris-sigur/openwayback that referenced this issue Mar 31, 2015
@kris-sigur
Updated release notes with fix to issue iipc#231
dbcf7f5
kris-sigur pushed a commit to kris-sigur/openwayback that referenced this issue Mar 31, 2015
@rossh @kris-sigur
iipc#231 - Fixed a problem returning back maximum day of month.
152e753
kris-sigur added a commit to kris-sigur/openwayback that referenced this issue Mar 31, 2015
@kris-sigur
Updated release notes with fix to issue iipc#231
479005b
@kris-sigur kris-sigur mentioned this issue Mar 31, 2015
Merged
kris-sigur pushed a commit that referenced this issue Mar 31, 2015
Merge pull request #233 from kris-sigur/Issue-231
e9cb41e 
Issue #231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0 Minor Release
Development

No branches or pull requests
2 participants
@rossh @kris-sigur