Added 'accessPointPath' to default proxy config. #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not set "internalPort". More specific and cosistent with rest of the file. |
|
Does "internalPort" work? I thought the request router only checked the accessPointPath, but I may be wrong. I agree "internalPort" would be better if it works. |
|
Nevermind, see internalPort is already set. Strange that that wasnt enough. Need to clean up AccessPoint config at some point. |
|
I guess we'd like to get this change into 2.0.0. I agree that AccessPoint config should be cleaned up, but not for 2.0.0. If there are no objections, I will merge this pull request. |
johnerikhalse
added a commit
that referenced
this pull request
Sep 11, 2014
Added 'accessPointPath' to default proxy config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on the openwayback-dev mailing list, there seems to be a problem with proxy-mode in recent releases. Add the
accessPointPathto the default config. resolves this.